Review Request 129155: reviewboard-am: add Python 3 compatibility

2016-10-11 Thread Peter Wu
Description --- Tested with Python 2.7.12 and 3.5.2. Diffs - reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 Diff: https://git.reviewboard.kde.org/r/129155/diff/ Testing --- (Note: changes the same context as review 129154.) Thanks, Peter Wu

Review Request 129154: reviewboard-am: add marker to ignore following text

2016-10-11 Thread Peter Wu
--- Tested with https://git.reviewboard.kde.org/r/129137/ which somehow has retained the text in the diff: https://git.reviewboard.kde.org/r/129137/diff/raw/ Thanks, Peter Wu

Re: Review Request 129155: reviewboard-am: add Python 3 compatibility

2016-10-12 Thread Peter Wu
marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Submitted with commit a19ca72213586a05d6aff67c6562b3c60c5b012f by Peter Wu to branch master. Repository: kde-dev-scripts Description --- Tested with Python 2.7.12 and 3.5.2. Diffs

Re: Review Request 129154: reviewboard-am: add marker to ignore following text

2016-10-12 Thread Peter Wu
marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Submitted with commit 6221fbec096fc31a16a8f644714342e7c52d3216 by Peter Wu to branch master. Repository: kde-dev-scripts Description --- Raw patches from reviewboard can contain additional text

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Peter Wu
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95727, @ossi wrote: > please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path). I suspect it is a kernel bug,

D4975: Prevent misdetection of EOF on Linux

2017-03-17 Thread Peter Wu
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95754, @ossi wrote: > first try googling it; maybe there is even a response on stackoverflow (as so often happens). Was one of the first things to try, that only pointed to an issue in Emacs and another that

D4975: Prevent misdetection of EOF on Linux

2017-03-08 Thread Peter Wu
Lekensteyn created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Linux, even if slave activity is detected on a master fd, FIONREAD can still return zero available bytes in the buffer. Previously

D4975: Prevent misdetection of EOF on Linux

2017-04-26 Thread Peter Wu
Lekensteyn added a comment. (FWIW, I ran a patched kpty 5.32.0-1 version for a while and didn't have the hang issue until I recently upgraded to an unpatched 5.33.0-1. Haven't had a moment so far to dig deeper into the issue though.) REPOSITORY R291 KPty REVISION DETAIL

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-02-26 Thread Peter Wu
Lekensteyn added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19027 To: Lekensteyn, ngraham, dfaure, fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-03-03 Thread Peter Wu
Lekensteyn updated this revision to Diff 53066. Lekensteyn marked 2 inline comments as done. Lekensteyn added a comment. @dfaure I've replaced the outdated comment, how does this version look? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19027?vs=51736=53066

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-03-03 Thread Peter Wu
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d8fcc1e8c62c: Fix Invalid URL: QUrl(some.txt) warnings in Save dialog (authored by Lekensteyn). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19027?vs=53066=53080

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-02-15 Thread Peter Wu
Lekensteyn updated this revision to Diff 51736. Lekensteyn added a comment. Added context, I thought that it would be looked up by Phabricator once linked to a repo. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19027?vs=51726=51736 REVISION DETAIL

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-02-14 Thread Peter Wu
Lekensteyn created this revision. Lekensteyn added reviewers: ngraham, dfaure, fvogt. Lekensteyn added a project: Frameworks. Lekensteyn requested review of this revision. REVISION SUMMARY When the Save File dialog is in use with filters, any relative path would trigger warnings due to

D21367: kioexec: change the scary debug messages for delayed deletion

2019-05-25 Thread Peter Wu
Lekensteyn updated this revision to Diff 58640. Lekensteyn marked an inline comment as done. Lekensteyn edited the test plan for this revision. Lekensteyn added a comment. Addressed review comment by adding a constant for the interval. Changed minutes -> seconds in the debug message. CHANGES

D21367: kioexec: change the scary debug messages for delayed deletion

2019-06-02 Thread Peter Wu
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb5a3ac8ff22: kioexec: change the scary debug messages for delayed deletion (authored by Lekensteyn). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21367: kioexec: change the scary debug messages for delayed deletion

2019-05-27 Thread Peter Wu
Lekensteyn updated this revision to Diff 58714. Lekensteyn set the repository for this revision to R241 KIO. Lekensteyn added a comment. Using camelCase now. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21367?vs=58640=58714 REVISION DETAIL

D21367: kioexec: change the scary debug messages for delayed deletion

2019-05-23 Thread Peter Wu
Lekensteyn created this revision. Lekensteyn added reviewers: elvisangelaccio, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Lekensteyn requested review of this revision. REVISION SUMMARY After resuming my laptop, I found this scary message in