phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.
REVISION SUMMARY
The rexx syntax highlighting was incomplete. It
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.
REVISION SUMMARY
There was no support for CLIST syntax
phily created this revision.
phily added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
phily requested review of this revision.
REVISION SUMMARY
There is currently no support for JCL (Job
phily updated this revision to Diff 44277.
phily marked an inline comment as done.
phily added a comment.
Making changes based on reviewer comments.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16415?vs=44181=44277
REVISION DETAIL
phily marked an inline comment as done.
phily added a comment.
Thank you for the feedback. I've gone and updated the syntax file to explain
what JCL is and remove the `^` from the regex. Thank you for the suggestions.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
phily updated this revision to Diff 44278.
phily marked 5 inline comments as done.
phily added a comment.
Fixing issues noted by reviewer
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16416?vs=44182=44278
REVISION DETAIL
phily added a comment.
Example CLIST can be viewed here:
https://gist.githubusercontent.com/mainframed/9e9c85b7a13186e7ca51b5b47d90b575/raw/1e19fede7d203585b213d2f20700ed08baac9e07/protall.clist
Looking at the code repo I wasn't sure exactly where to include the code
examples.
phily updated this revision to Diff 44281.
phily added a comment.
Added test file to autotests/input/test.rexx as well as upgrading the version
number
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16414?vs=44180=44281
REVISION DETAIL
phily updated this revision to Diff 44282.
phily added a comment.
Did not include the syntax file itself in my last update, now the diff
includes both.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16414?vs=44281=44282
REVISION DETAIL
phily updated this revision to Diff 44283.
phily added a comment.
Removed typo in test script
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16414?vs=44282=44283
REVISION DETAIL
https://phabricator.kde.org/D16414
AFFECTED FILES
phily updated this revision to Diff 44454.
phily added a comment.
Adding test file for JCL and making removing hard coded colors.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16415?vs=44277=44454
REVISION DETAIL
phily added a comment.
In D16416#349335 <https://phabricator.kde.org/D16416#349335>, @cullmann wrote:
> To properly push it with you as author, what is your full name + mail
address?
Phil Young
mainframed...@gmail.com
(I'm assuming you meant email address)
R
phily updated this revision to Diff 44457.
phily added a comment.
- Added JCL test program as well as fixing recommendations (no hard coded
colors)
- Added new highlighting of steps (vs program options)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
13 matches
Mail list logo