D11925: Add "SkipSwitcher" to API

sharvey added a dependent revision: D11926: Add "SkipSwitcher" to API. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#255082 , @lbeltrame wrote: > For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated. Thank you for reverting the commit. The one - and only - reason

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 34636. sharvey added a comment. - Increate interface versions for PlasmaShell and PlasmaWindowManagement REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=32996=34636 BRANCH arcpatch-D11925 REVISION DETAIL

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#265446 , @graesslin wrote: > any update on this? It's just the version increase in registry.cpp which is missing... Done. I was unclear as to what needed to change. I got a little outside help from

D11925: Add "SkipSwitcher" to API

This revision was automatically updated to reflect the committed changes. Closed by commit R127:10b00a219e9f: Add SkipSwitcher to API (authored by sharvey). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=34636=34654 REVISION DETAIL

D14516: Open `skipPager` functionality

sharvey added a reviewer: Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14520: Open `skipPager` functionality

sharvey added a comment. Okay, a clean copy. Apologies for the mess. I can do the coding, but the infrastructure is another story... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, hein Cc: kde-frameworks-devel, ngraham,

D14516: Open `skipPager` functionality

sharvey abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14520: Open `skipPager` functionality

sharvey updated this revision to Diff 38863. sharvey added a comment. - Remove wrongly committed files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14520?vs=38862=38863 BRANCH arcpatch-D14516 REVISION DETAIL https://phabricator.kde.org/D14520

D14516: Open `skipPager` functionality

sharvey updated this revision to Diff 38859. sharvey added a comment. Remove untracked `.arclint` and `CMakeLists.txt.user` REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14516?vs=38854=38859 BRANCH add-skip-pager (branched from master) REVISION

D14516: Open `skipPager` functionality

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. sharvey requested review of this revision. REVISION SUMMARY Open `skipPager` functionality, same as `skipTaskbar`

D14516: Open `skipPager` functionality

sharvey added a comment. Plasma team: Please help me review and fix the failing autotests. I'm not familiar enough with the internals of KWayland - or autotests - to successfully debug what's happening. The patch builds and compiles without error. Thanks for your help. REPOSITORY

D14516: Open `skipPager` functionality

sharvey added a comment. In D14516#301385 , @ngraham wrote: > Changes to `.arclint` look unintended, and I'm not sure you meant to check in `CMakeLists.txt.user`. The changes are intentional - my arc seems to be broken. It wasn't

D14516: Open `skipPager` functionality

sharvey added a comment. There's no functionality to remove files. I'll submit a new diff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14520: Open `skipPager` functionality

sharvey created this revision. sharvey added reviewers: Plasma on Wayland, hein. sharvey added a project: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Open `skipPager` functionality, same as `skipTaskbar` REVIEWER NOTE: Several of the autotests are failing, although

D14520: Open `skipPager` functionality

sharvey marked an inline comment as done. sharvey added a comment. Hopefully `.arclint` is gone for good this time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, hein, #plasma, romangg, davidedmundson Cc: zzag,

D14520: Open `skipPager` functionality

sharvey updated this revision to Diff 38877. sharvey added a comment. - Whitespace fix & remove .arclint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14520?vs=38863=38877 BRANCH arcpatch-D14516 REVISION DETAIL https://phabricator.kde.org/D14520

D12311: Align lock icon with bold message text; reduce overall size of dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; reduce overall size of dialog (authored by sharvey). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. I believe it's done. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano,

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey edited the summary of this revision. sharvey added reviewers: ngraham, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked an inline comment as done. sharvey added a comment. In D11993#241387 , @ngraham wrote: > This patch is a breath of fresh air when using Detailed View or Detailed Tree View. You can resize the window and open and close the preview

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. F5795938: Screenshot_20180406_145748.png Before (from user bug report) F5795942: Screenshot_20180406_145619.png After (mine) REPOSITORY R241 KIO REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > broulik wrote in kdiroperatordetailview.cpp:103 > For first colum you want to set it to `0`, here it blew up the "Size" column > to full width I got misled by my manual adjustment of the columns from

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31517. sharvey added a comment. - Fix incorrect column index REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31516=31517 BRANCH column-widths (branched from master) REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adjust column sizing options so that "last" column is no longer the largest. First column

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked 3 inline comments as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperatordetailview_p.h:56 > Don't leave code commented out like this; if it's not used anymore, delete it! Remnants of testing. Won't do that again. REPOSITORY R241 KIO BRANCH

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. Give me a moment to comment it out again and re-check. I thought it was, but let me run another test. REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: broulik,

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31545. sharvey added a comment. - Remove leftover commented-out code; restore variable declaration REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31540=31545 BRANCH arcpatch-D11993 REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. In the works... REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31540. sharvey added a comment. - Remove unneeded resize code; ensure other columns fill to contents REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31517=31540 BRANCH arcpatch-D11993 REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. All seems to be well with the removal of the extraneous resizing code. Here's the result of a test with a ridiculously long filename: F5796698: Screenshot_20180406_195204.png I think that looks perfectly reasonable.

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. Also, yes - Stretch has disabled the ability to manually resize the columns. Columns 1 & 2 are set to fit the size of their contents, while column 0 fills all the remaining space. Resizing the dialog results in only the Name column (column 0) to change size; the

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. I'll give that a test. I'm sure I can find a file (or make one up) with an absurdly long filename. Once I figure out why @ngraham's uploaded diff won't apply... grr. REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL

D11924: Add "SkipSwitcher" to API

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add "SkipSwitcher" to API". REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol,

D11924: Add "SkipSwitcher" to API

sharvey added a comment. Thanks, @graesslin. I enjoyed this challenge. I removed the `[WIP]` tag from the title. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham,

D11924: [WIP] Add "SkipSwitcher" to API

sharvey edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. NOTE: This is a junior job and a work in progress! After discussion in BUG 375921 , it was decided to add `SkipSwitcher` to the KWin API. It's a junior job and my first submission to the KWin/KWayland/KWindowSystem

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added inline comments. INLINE COMMENTS > plasmawindowmodel.h:110 > +/** > + * @since 5.?? > + */ Correct version number? 5.45? > plasmashell_interface.h:144 > + * in a window switcher > + * @since 5.?? > + **/ Version 5.45? REPOSITORY R127

D11924: [WIP] Add "SkipSwitcher" to API

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adding "SkipSwitcher" to API, stemming from discussion in BUG

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. NOTE: This is a junior job and a work in progress! Following discussion in BUG 375921 , it was decided to add `SkipSwitcher` to the API. This is my first submission to the KWin/KWayland/KWindowSystem group, and @hein

D11925: [WIP] Add "SkipSwitcher" to API

sharvey edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adding "SkipSwitcher" to API, as a result of discussion in BUG

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. F5787709: kwayland-test-exception.txt KWayland test results / exception report REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added inline comments. INLINE COMMENTS > apol wrote in netwm_def.h:492 > add `@since 5.45`? Will it be `5.45` for KWayland as well? There were `@since` tags in what I duplicated, but I wasn't certain which version. REPOSITORY R278 KWindowSystem REVISION DETAIL

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: apol, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

sharvey marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

sharvey marked 2 inline comments as done. sharvey added inline comments. INLINE COMMENTS > graesslin wrote in plasmawindowmodel.h:110 > I normally update those just before pushing to the next frameworks release > number. Sorry. Was busy uploading before seeing your reply. Will gladly change

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#239922 , @apol wrote: > 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it later if it takes us longer to merge). I took a minute to think it through and came to the conclusion of

D11925: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31308. sharvey added a comment. - Add `@since 5.45` tag to SkipSwitcher doxygen comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31296=31308 BRANCH skip-switcher (branched from master) REVISION

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31307. sharvey added a comment. - Add `@since 5.45` to SkipSwitcher doxygen comments REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31294=31307 BRANCH skip-switcher (branched from master) REVISION

D11925: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31311. sharvey marked an inline comment as done. sharvey added a comment. - Correct & update version numbers in XML entries REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31308=31311 BRANCH skip-switcher

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31992. sharvey marked an inline comment as done. sharvey added a comment. - Remove unneeded resize code; ensure other columns fill to contents - Remove leftover commented-out code; restore variable declaration REPOSITORY R241 KIO CHANGES SINCE LAST

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land now. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank,

D12160: Rebase onto fresh master

sharvey abandoned this revision. sharvey added a comment. Created by mistake. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D12160: Rebase onto fresh master

sharvey added a comment. In D12160#245232 , @ngraham wrote: > Oops, did you mean to create a new revision? Let's just focus on the existing one. git and arc are hating me right now REPOSITORY R241 KIO REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 32002. sharvey added a comment. - Repairing merge error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31992=32002 BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 AFFECTED FILES

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked 2 inline comments as done. sharvey added a comment. Merge errors tracked down and eradicated. INLINE COMMENTS > ngraham wrote in kdiroperatordetailview.cpp:53 > Uh-oh :) What is that? (finding it and killing it) REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION

D12034: Use the more appropriate "two sliders" icon for "configure"

sharvey added a comment. Since I may or may not have been the one to bring this to @ngraham's attention, I'll offer my two cents and be done. - The mini/mono slider icons for widget & panel configs, are, I believe, hardcoded and drawn from Breeze. - The full-size two-slider icon for

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#240057 , @graesslin wrote: > In D11924#240045 , @graesslin wrote: > > > I'm not sure whether we can add elements to the states. > > An

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a subscriber: ngraham. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31330. sharvey added a comment. - Add `_KDE` prefix to SkipSwitcher state; correct enum REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31307=31330 BRANCH skip-switcher (branched from master) REVISION

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked 3 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812014: Screenshot_20180418_155156.png The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a separate process?). I don't have a HiDPI display to test on. I tried different fonts up to 15pt and all

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812033: Screenshot_20180418_161500.png The good news is that it still behaves properly with a scaled display. The bad news is that, due to the `minimumSize` we configured for System Settings, I can't get back to the

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Reviewers: as part of my task to redesign and tidy up this dialog box, I'm considering removing the Details button in the bottom left corner, along with the small pop-open panel that shows additional information. My argument is that the info in the Details panel is

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a subscriber: stikonas. sharvey added a comment. Semi-related bug from @stikonas, while I'm on dialog duty: https://bugs.kde.org/show_bug.cgi?id=393355 REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Hmm, I was actually leaning the other way. Ditch the generic boilerplate and keep the app-specific text. I think it's helpful when the dialog tells you why it appeared and what app/function is requesting your password. REPOSITORY R121 Policykit (Polkit) KDE Agent

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. The small-text boilerplate is definitely on the chopping block. @ltoscano makes a fine case for keeping the Details section. @bruns - Thanks for helping me find the source of the incoming messages. I hadn't gotten around to searching for them yet, but you saved

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey updated this revision to Diff 32758. sharvey added a comment. - Merge branch 'master' into align-lock-icon - Undo manual resizing of ser combo box & password error box REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Okay, this patch is back to where we started, with nothing changed except centering the icon. Hopefully we can commit it now. I'll move the discussion over how to redesign the dialog itself to a separate task. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. FYI: I undid the wonky manual UI sizing that @broulik objected to. In hindsight, not the best approach. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey,

D12321: Hide file preview when icon is too small

sharvey added a comment. In D12321#249568 , @anemeth wrote: > (effective screencast) +1 from me, and you beat me to it.  I was just looking through the code when Thunderbird chimed that I had new mail. For the sake of

D11925: Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 32996. sharvey added a comment. - Update PlasmaWindowManagement interface to version 9 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=32906=32996 BRANCH arcpatch-D11925 REVISION DETAIL

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#253074 , @graesslin wrote: > The adjustments in registry.cpp are still missing. I apologize, but I don't know what adjustments to make in `registry.cpp`. In all other cases, I followed the templates

D11925: Add "SkipSwitcher" to API

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add "SkipSwitcher" to API". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

sharvey added a subscriber: davidedmundson. sharvey added a comment. Removed `[WIP]` from title at suggestion of @davidedmundson . REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin,

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 32906. sharvey added a comment. - Update interface version number; move setSkipSwitcherCallback to end of struct REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31311=32906 BRANCH arcpatch-D11925 REVISION

D11925: Add "SkipSwitcher" to API

sharvey marked 3 inline comments as done. sharvey added a comment. Changes made. KWayland compiles fine now. Thank you. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh,

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a comment. Also, related patches D11925 and D11926 are still open and uncommitted. I'm unclear if those missing pieces are affecting the autotests. REPOSITORY R278 KWindowSystem REVISION DETAIL

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a comment. I'm afraid to admit I don't understand it all that well myself. This is my first submission to KWindowSystem. It was supposed to be a straightforward case of "implement `skipSwitcher` just like `skipTaskbar` is implemented". I believe I noted the problems with the

D12077: Show view mode buttons in the open/save dialog's toolbar

sharvey added a comment. +1 for making things easier and prettier. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. Polite "bump" for my reviewers. Please see D12363 - the Kubuntu team has had to manually disable some autotests stemming from D11924 . REPOSITORY R127 KWayland REVISION DETAIL

D11924: Add "SkipSwitcher" to API

sharvey added a subscriber: Plasma. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: #plasma, ngraham, graesslin, apol, #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a subscriber: Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a subscriber: Plasma. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D12363 To: joselema, graesslin, hein, sharvey Cc: #plasma, rikmills, #frameworks, michaelh, bruns

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

sharvey added a comment. +1. Don't use 'em, won't miss 'em. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: sharvey, elvisangelaccio, abetts, rizzitello, michaelh, ngraham