Review Request 120132: correct documentation for overlays parameter

2014-09-10 Thread Stefan Brüns
--- The current documentation is incorrect, as no 'emblem' prefix is added to the overlay name. Also there is no mention how the emblems are placed. Instead of giving a complete definition, reference the drawOverlays method. Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-10 Thread Stefan Brüns
framework - Stefan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120132/#review66195 --- On Sept. 10, 2014, 9:24 p.m., Stefan Brüns

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
the drawOverlays method. Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - tier3/kiconthemes/src/kiconloader.h a32734564786ab1bd7920ce13339f7f8713d9260 Diff: https://git.reviewboard.kde.org/r/120132/diff/ Testing --- Thanks, Stefan Brüns

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
On Sept. 10, 2014, 9:31 p.m., Luigi Toscano wrote: I guess this is about frameworks branch. If yes, please ignore it, as it has been split into the several framework repositories; check if the issue applies in the separate KIconThemes framework. Stefan Brüns wrote: patch applies

Review Request 120142: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
Brüns stefan.bru...@rwth-aachen.de Diffs - src/kiconloader.h 46d3017e703c38bfa4da9e5cb721b0c596a26815 Diff: https://git.reviewboard.kde.org/r/120142/diff/ Testing --- Thanks, Stefan Brüns ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 120142: correct documentation for overlays parameter

2014-09-18 Thread Stefan Brüns
. Instead of giving a complete definition, reference the drawOverlays method. Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/kiconloader.h 46d3017e703c38bfa4da9e5cb721b0c596a26815 Diff: https://git.reviewboard.kde.org/r/120142/diff/ Testing --- Thanks, Stefan

Review Request 120605: cleanup overlay icon usage

2014-10-16 Thread Stefan Brüns
-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c Diff: https://git.reviewboard.kde.org/r/120605/diff/ Testing --- Patched kio, see BR for new screenshot Thanks, Stefan Brüns

Re: Review Request 120605: cleanup overlay icon usage

2014-10-18 Thread Stefan Brüns
? - Stefan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68567 --- On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Stefan Brüns
--- On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605

Re: Review Request 120605: cleanup overlay icon usage

2014-11-10 Thread Stefan Brüns
with .gz file ending, there is a mimetype icon for gzip files. BUGS: 339193 Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c Diff: https://git.reviewboard.kde.org/r/120605/diff/ Testing --- Patched kio

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-17 Thread Stefan Brüns
/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f Diff: https://git.reviewboard.kde.org/r/122652/diff/ Testing --- dolphin remote: - no lock icon on smb:, mtp:, ... links Thanks, Stefan Brüns ___ Kde-frameworks-devel mailing list Kde

Review Request 123972: Clarify exit value for Unique instances

2015-05-31 Thread Stefan Brüns
--- The default exit value for a duplicate instance is 0, if not set from the already-running application. Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/kdbusservice.h 8dd6357419c64e0b5a1eca6f3f56c760f8c398fa Diff: https://git.reviewboard.kde.org/r/123972

Re: Review Request 123972: Clarify exit value for Unique instances

2015-06-28 Thread Stefan Brüns
marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kdbusaddons Description --- The default exit value for a duplicate instance is 0, if not set from the already-running application. Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs

Re: Review Request 124413: Enable PAM opening KWallet again

2015-07-21 Thread Stefan Brüns
On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string is

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

2015-10-22 Thread Stefan Brüns
> On Oct. 22, 2015, 4:32 p.m., Frank Reininghaus wrote: > > 4096 bytes looks reasonable. I think I would still find a fail-safe > > solution with a dynamically increasing buffer prettier, but it's so > > extremely unlikely that this will ever cause problems that it's not worth > > arguing

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-19 Thread Stefan Brüns
tps://git.reviewboard.kde.org/r/129720/#comment68240> This is broken: if (plugins.isEmpty()) { ... for (; it != d->m_extractors.constEnd(); it++) { if (plugins.contains( some_value ) The "plugins.contains(...)" is always false. - Stefan Brüns On

D5034: Add support for x-gvfs style options in fstab

2017-04-06 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > fstabdevice.cpp:47 > > -m_description = m_vendor + " on " + m_product; > +const QStringList = > FstabHandling::options(m_device).filter("x-gvfs-"); > + Why QStringList& instead of QStringList? > fstabdevice.cpp:51 > +if

D5034: Add support for x-gvfs style options in fstab

2017-07-11 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > fstabstorageaccess.cpp:48 > > +const QStringList = FstabHandling::options(device->device()); > +// GVFS by default doesn't show devices outside of /media, $HOME (and > some other locations) Another useless use of const QList&,

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-05-27 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130058/#review103250 --- Thanks for pushing this upstream! - Stefan Brüns On May

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns removed a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns removed a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns added a dependent revision: D7774: [solid/fstab] Add support for x-gvfs style options in fstab. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

2017-09-11 Thread Stefan Brüns
bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7774 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

2017-09-11 Thread Stefan Brüns
bruns created this revision. bruns added projects: Plasma, Frameworks. REVISION SUMMARY This fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is subordinate

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-11 Thread Stefan Brüns
bruns added a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

2017-09-12 Thread Stefan Brüns
bruns updated this revision to Diff 19458. bruns added a comment. Remove erroneous const, takeFirst requires a mutable list REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7774?vs=19418=19458 BRANCH master REVISION DETAIL

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

2017-09-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R245:f299edfeb8fd: [solid/fstab] Swap vendor and product properties, allow i18n of description (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

2017-09-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R245:9929fc8fbdcb: [solid/fstab] Add support for x-gvfs style options in fstab (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7774?vs=19458=19949

D11745: databasesanitizer: Use flags for filtering

2018-04-04 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.h:41 > +IgnoreUnavailable = 2, > +IgnoreMounted = IgnoreAvailable << 1, > +IgnoreUnmounted = IgnoreUnavailable << 1 Is this correct? IgnoreMounted = (1 << 1) = 2 == IgnoreUnavailable? REPOSITORY R293

D11888: Handle adjacent special characters correctly

2018-04-04 Thread Stefan Brüns
bruns marked 8 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

2018-04-04 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in databasesanitizer.cpp:333 > I did that before, but decided on `--dry-run` to simulate the process as > close as possible. > Also, compared to the time it takes to collect the data, removing the docs is > completely neglectible.

D11828: Simplify orPostingIterator and make it faster

2018-04-06 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > orpostingiterator.cpp:44 > { > -m_docId = 0; > -if (m_iterators.isEmpty()) { > -return 0; > +// first call > +if (m_nextId == 0) { Move this to the constructor? > orpostingiterator.cpp:47 > +for (auto it =

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > advancedqueryparsertest.cpp:229 > +QTest::addColumn("failmessage"); > +const QString nofail; > +QString searchInput; remove >

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns added a comment. Can you add the output of the failing tests here verbatim? INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:264 > This test fails. "no optimization" serves as a flag, that it's expected to > fail and as message why. See lines 217-219. That's why I

D11907: advancedqueryparsertest: Add more test

2018-04-05 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:235 > +<< Term{Term::And, QList{ > +Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}, > +Term{QStringLiteral(""), QStringLiteral("b"), Term::Contains}, `Term{QString(),

D11753: baloodb: Add clean command

2018-04-05 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in databasesanitizer.cpp:333 > 8 meanings of MOOD acronym or abbreviation. > MOOD stands for > > Magic of Ordinary Days > Meet only Original Designs > Michigan Out of Doors > Movie Organizer Online Database > Miata Owners

D11452: sanitizer: Improve device listing

2018-04-05 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:251 > +// TODO coloring would be nice, but "...|grep '^!'" does not work > with it. > +// out << QStringLiteral("%1").arg(dev.mounted ? "+" : "\033[1;31m!") > +out <<

D11907: advancedqueryparsertest: Add more test

2018-04-05 Thread Stefan Brüns
bruns added a dependent revision: D11826: Simplify Term operator&& and ||. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

2018-04-05 Thread Stefan Brüns
bruns added a dependency: D11907: advancedqueryparsertest: Add more test. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

2018-04-06 Thread Stefan Brüns
bruns added a dependent revision: D12005: Fix merging of terms in the AdvancedQueryParser. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun,

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The code merged compatible terms only if the left hand

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns added a dependency: D11826: Simplify Term operator&& and ||. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Ok, this is ready now. Thanks! REPOSITORY R293 Baloo BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo,

D11826: Simplify Term operator&& and ||

2018-04-06 Thread Stefan Brüns
bruns updated this revision to Diff 31541. bruns edited the test plan for this revision. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31160=31541 BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 AFFECTED FILES

D12006: Make list of subterms in debug output easier to spot

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY '(' was used for both delimiting Terms and list of

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11826: Simplify Term operator&& and ||

2018-04-07 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:b0dcc732ca98: Simplify Term operator and || (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31581=31582 REVISION DETAIL

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Parsing of e.g. "a OR ((b AND c) AND d)" currently

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Stefan Brüns
bruns added a dependent revision: D11888: Handle adjacent special characters correctly. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns updated this revision to Diff 31550. bruns added a comment. token.size() > 0 -> !token.isEmpty() renamed tokens to tokenList Use testcase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11888?vs=31161=31550 BRANCH

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns marked 6 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns added a dependency: D12007: Add test case for parsing of double opening '(('. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11826: Simplify Term operator&& and ||

2018-04-07 Thread Stefan Brüns
bruns updated this revision to Diff 31581. bruns added a comment. rebased REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31541=31581 BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 AFFECTED FILES

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-07 Thread Stefan Brüns
bruns updated this revision to Diff 31585. bruns added a comment. rebased REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12005?vs=31543=31585 BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 AFFECTED FILES

D12006: Make list of subterms in debug output easier to spot

2018-04-07 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:04f972a7f551: Make list of subterms in debug output easier to spot (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12006?vs=31546=31586 REVISION

D11907: advancedqueryparsertest: Add more test

2018-04-05 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:255 > What about this one? Drop it? I think it should stay as it exercises the stack in the query parser Pseudocode: s[0] = a, AND s[1] = b, AND t = construct (c AND d) t = Term( s[1].term, t,

D12025: Terminate query execution early if subterm returns empty result set

2018-04-07 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Leaf queries may return an empty result set, which is

D11828: Simplify orPostingIterator and make it faster

2018-04-07 Thread Stefan Brüns
bruns updated this revision to Diff 31623. bruns added a reviewer: michaelh. bruns added a comment. cleanup REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=31008=31623 BRANCH speedup_orpostingoperator REVISION DETAIL

D12037: Immediately apply termInConstruction when term is complete

2018-04-08 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:c7c5a0bffbea: Immediately apply termInConstruction when term is complete (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12037?vs=31638=31682

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-08 Thread Stefan Brüns
bruns updated this revision to Diff 31685. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12005?vs=31585=31685 BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 AFFECTED FILES autotests/unit/lib/advancedqueryparsertest.cpp

D12007: Add test case for parsing of double opening '(('

2018-04-08 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:4e69ffeab75f: Add test case for parsing of double opening (( (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12007?vs=31634=31679 REVISION

D12045: Clean up existing documentation

2018-04-08 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > README.md:5 > > -Baloo provides file searching and indexing. It does so by maintaining an > index of the contents > -of your files. > +Baloo is the file indexing and file search framework for KDE Plasma. It > focuses on speed and a very small

D12047: Avoid crash when reading corrupt data from document terms db

2018-04-08 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The terms db contains terms, where each terms is stored

D12044: baloodb: Improve interface

2018-04-08 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:249 > if (!(accessFilter & IgnoreAvailable)) { > -out << QStringLiteral("%1").arg(info.accessible ? "+" : "!") << > sep; > +color = (useColors && !info.accessible) ? colors.first : >

D11888: Handle adjacent special characters correctly

2018-04-08 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:116e55a2076e: Handle adjacent special characters correctly (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11888?vs=31636=31681 REVISION DETAIL

D12047: Avoid crash when reading corrupt data from document terms db

2018-04-08 Thread Stefan Brüns
bruns added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12051: [UDisks] Correct handling of removable file systems

2018-04-08 Thread Stefan Brüns
bruns added a dependency: D12050: Make automounting work even if StorageAccess is ignored. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12051 To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns

D12045: Clean up existing documentation

2018-04-08 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > README.md:27 > +* Baloo follows the > [KDELibs](https://techbase.kde.org/Policies/Kdelibs_Coding_Style) coding > style. > +* [![Build >

D12051: [UDisks] Correct handling of removable file systems

2018-04-08 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: ngraham, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Filesystems which have no fstab entry have an empty filepath

D11828: Simplify orPostingIterator and make it faster

2018-04-09 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in orpostingiterator.cpp:71 > Newbie question: Does std::unique_ptr make sense here? When writing from scratch today, yes. But this would not disallow nullptr (`std::make_unique(nullptr)` is fully valid) REPOSITORY R293 Baloo

D11745: databasesanitizer: Use flags for filtering

2018-04-09 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:100 > QTextStream err(stderr); > for (quint64 id: keys) { > printProgress(err, i, max, 100); As you are not iterating over sorted keys, just directly iterate on the map. >

D11828: Simplify orPostingIterator and make it faster

2018-04-09 Thread Stefan Brüns
bruns added a comment. In D11828#242402 , @michaelh wrote: > I'm not very familiar with the concept of iterators (yet). To me it looks like `auto i = new OrPostingIterator(iters); i->docId();` will return 0 and `i->next()` returns a valid

D11828: Simplify orPostingIterator and make it faster

2018-04-09 Thread Stefan Brüns
bruns added a comment. In D11828#242372 , @michaelh wrote: > While reading in IDE realized `(*it)` resolves to `PostingIterator**` I got a little dizzy at first, then started to play with this code and came up with this. > In Constructor:

D11745: databasesanitizer: Use flags for filtering

2018-04-10 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:116 > if ((!includeIds.isEmpty() && > !includeIds.contains(info.deviceId)) > || (!excludeIds.isEmpty() && > excludeIds.contains(info.deviceId)) > || (urlFilter &&

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-10 Thread Stefan Brüns
bruns added a comment. Thats a new one REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: bruns, abetts, sharvey, #frameworks, michaelh, ngraham

D12034: Use the more appropriate "two sliders" icon for "configure"

2018-04-10 Thread Stefan Brüns
bruns added a comment. +1 for making it more consistent ... For the design - how about this one (Shortcuts - old, Toolbars - new)? F5803306: Screenshot_20180410_224347.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D12123: [UDisks] Optimize several property checks

2018-04-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Use QStringLiteral for hasInterface argument Retrieve MountPoints propery just once when checking mount state.

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

2018-04-11 Thread Stefan Brüns
bruns created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY UDisks2 added a "Size" property for the Filesystem interface, which may be zero, denoting an

D12126: Invalidate property cache when an interface is removed

2018-04-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY As we do not know which property belongs to which interface we have to drop the whole cache whenever one or multiples

D12127: Do not query properties when no interfaces are left

2018-04-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY checkCache is indirectly invoked from DeviceManager::updatebackend(), e.g. after an InterfaceRemoved call. Avoid doing

D12028: taglibextractortest: Add test for files with empty metadata

2018-04-11 Thread Stefan Brüns
bruns added a comment. In D12028#244257 , @michaelh wrote: > In D12028#244243 , @mgallien wrote: > > > I need more time. I will try to look at it today. By the way, the stack concept seems very

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns added a dependent revision: D12125: Avoid inserting an invalid "Size" property from the Filesystem interface. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12124 To: bruns, #frameworks Cc: michaelh, ngraham, bruns

D12028: taglibextractortest: Add test for files with empty metadata

2018-04-11 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractortest.cpp:231 > This converts the enums to strings. That way it is easier to spot which > properties are responsible for the failure. What he likely meant: `TagLibExtractor plugin{this};` instead of `QScopedPointer

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

2018-04-11 Thread Stefan Brüns
bruns added a dependency: D12124: Avoid creating duplicate property entries in the cache. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns Cc: #frameworks, michaelh, ngraham, bruns

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Properties are associated with a specific interface, although the Solid UDisks2 backend merges properties from all

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns updated this revision to Diff 31929. bruns added a comment. update, one line was missing REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12124?vs=31928=31929 BRANCH unique_properties REVISION DETAIL https://phabricator.kde.org/D12124 AFFECTED

D12045: Clean up existing documentation

2018-04-11 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > michaelh wrote in README.md:36 > - In CI Baloo is fully built and tested for Linux and FreeBSD. > - In CI an untested stub for Windows is build. I think that is to fulfill the > dependencies. > - macOS is not mentioned anywhere (and I don't know

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

2018-04-12 Thread Stefan Brüns
bruns added a reviewer: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns, #frameworks Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11452: sanitizer: Improve device listing

2018-04-12 Thread Stefan Brüns
bruns added a subscriber: ngraham. bruns added a comment. Looks good to me so far. If there are any issues, we can fix it up later IMHO. @ngraham as you reviewed other parts of the stack, can you do this one as well and accept? INLINE COMMENTS > databasesanitizer.cpp:257 > +<<

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

2018-04-12 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > broulik wrote in udisksdevicebackend.cpp:147 > So when size is unknown it will always query it as you will never have a Size > in the `m_propertyCache`? It uses the one from the Partition or Block Interface, see last paragraph from the Summary.

D12028: taglibextractortest: Add test for files with empty metadata

2018-04-12 Thread Stefan Brüns
bruns added a comment. Untested, but looks good to me otherwise. INLINE COMMENTS > taglibextractortest.cpp:42 > > +const QStringList TagLibExtractorTest::propertyEnumNames(const > QList& keys) const > +{ Nitpick - needs some indentation REPOSITORY R286 KFileMetaData REVISION DETAIL

D12145: autotests: Do not use QScopedPointer for plugins

2018-04-12 Thread Stefan Brüns
bruns added a comment. The first question is - why should we use pointers at all (raw, std::unique_ptr, QScopedPointer, ...) for objects **with local only scope**. The typical answer is Inheritance, see e.g. http://doc.qt.io/qt-5/qscopedpointer.html#details A `Base` pointer can be

D12124: Avoid creating duplicate property entries in the cache

2018-04-12 Thread Stefan Brüns
bruns added a comment. In D12124#244924 , @broulik wrote: > Wouldn't make a big difference, would it? > > > If there are multiple items for key in the map, the value of the most recently inserted one is returned. > > It's not like we

D12135: Allow disabling of CoW to fail when not supported by filesystem

2018-04-12 Thread Stefan Brüns
bruns added a comment. May I have another accept/review (for the stack) from #Frameworks or #Baloo ? REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL

  1   2   3   >