D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-05 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Frameworks, VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of D15929 for dolphin

D16141: Disable unmount option for / or /home

2018-10-11 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY This disables the 'Unmount' context menu in the Places panel for discs

D16141: Disable unmount option for / or /home

2018-10-12 Thread Thomas Surrel
thsurrel added a comment. In D16141#341553 , @ngraham wrote: > However, I'm afraid this doesn't actually work for me: That's strange, it is the same code than in Dolphin (and it works for me). Could you have a look at the

D16141: Disable unmount option for / or /home

2018-10-12 Thread Thomas Surrel
thsurrel added a comment. In D16141#341738 , @dfaure wrote: > This whole method could put placesModel->url(index) into a local variable to avoid calling it so many times, though. Should I do that here or in a different patch ?

D16141: Disable unmount option for / or /home

2018-10-12 Thread Thomas Surrel
thsurrel updated this revision to Diff 43443. thsurrel added a comment. Moved includes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16141?vs=43427=43443 BRANCH arc_unmount (branched from master) REVISION DETAIL https://phabricator.kde.org/D16141

D16141: Disable unmount option for / or /home

2018-10-12 Thread Thomas Surrel
thsurrel added a comment. If logged in as root, wouldn't QDir::homePath() return /root and not /home/ ? You should be able to unmount /home in that case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: broulik, ngraham,

D16141: Disable unmount option for / or /home

2018-10-12 Thread Thomas Surrel
thsurrel edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-24 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY It is already possible to create a directory with a keyboard shortcut (F10 in

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-24 Thread Thomas Surrel
thsurrel added a dependent revision: D16413: Add a keyboard shortcut to create file. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16412 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

2018-10-29 Thread Thomas Surrel
thsurrel added a comment. Ping ! Anyone from #frameworks could review this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-25 Thread Thomas Surrel
thsurrel marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16412 To: thsurrel, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 44202. thsurrel added a comment. Fixes as per elvisangelaccio Thank you very much for the review! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16412?vs=44178=44202 BRANCH newfileshortcut (branched from master)

D16313: Use QMenu::addSeparator

2018-10-19 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5001954b022a: Use QMenu::addSeparator (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16313?vs=43913=43914 REVISION DETAIL

D16313: Use QMenu::addSeparator

2018-10-19 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R241 KIO BRANCH arc_addseparator (branched from master) REVISION DETAIL

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Thomas Surrel
thsurrel edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16857 To: thsurrel, #dolphin, #frameworks, bruns Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D16141: Disable unmount option for / or /home

2018-11-13 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:45597c32627f: Disable unmount option for / or /home (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16141?vs=45378=45437 REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-15 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R295 KCMUtils BRANCH arc_focussearch (branched from master) REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-15 Thread Thomas Surrel
thsurrel added a dependent revision: D16914: [Runners KCM] Focus the search field by default. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

2018-10-04 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of https://phabricator.kde.org/D15938 for dolphin TEST PLAN In

D15973: Add a 'Properties' entry in the places panel context menu

2018-10-08 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6bbb80c2f9f2: Add a Properties entry in the places panel context menu (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=43071=43164

D15988: Add 'Mount' option to context menu of unmounted device in Places

2018-10-08 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:57f0d33d8e9a: Add Mount option to context menu of unmounted device in Places (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15988?vs=42979=43165#toc REPOSITORY R241

D16116: [KPropertiesDialog] Show a filename for the / directory

2018-10-10 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY The properties dialog was not showing anything in the window title and in

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Any folder laying in the / partition was excluded to have its 'Mounted on'

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel added a comment. F6303519: before.png F6303521: after.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh,

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel added a comment. Someone will have to land this, I don't have a developer account, thanks ! REPOSITORY R241 KIO BRANCH arc_rootdetails (branched from master) REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks, ngraham Cc: ngraham,

D15988: Add 'Mount' option to context menu of unmounted device in Places

2018-10-06 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of D15974 for dolphin

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-07 Thread Thomas Surrel
thsurrel marked an inline comment as done. REPOSITORY R241 KIO BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-06 Thread Thomas Surrel
thsurrel updated this revision to Diff 42984. thsurrel added a comment. Use isLocalFile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42945=42984 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-07 Thread Thomas Surrel
thsurrel updated this revision to Diff 43035. thsurrel added a comment. Don't use this-> REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42984=43035 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15973: Add a 'Properties' entry in the places panel context menu

2018-10-07 Thread Thomas Surrel
thsurrel updated this revision to Diff 43071. thsurrel added a comment. Show the KPropertiesDialog from the view instead of the model REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=43035=43071 BRANCH arc_properties (branched from master) REVISION

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-12-13 Thread Thomas Surrel
thsurrel updated this revision to Diff 47545. thsurrel added a comment. Create KUrlNavigator::isInsideCompressedPath Use this function instead of comparing the url scheme with tar, zip, ... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17270?vs=46589=47545

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-11-30 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY When we are navigating in an archive, trying to use the navigator buttons to

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-12-07 Thread Thomas Surrel
thsurrel added a comment. Thanks for the tip, I will try to use gammaray. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-12-03 Thread Thomas Surrel
thsurrel added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kurlnavigatorbutton.cpp:414 > Or we could use mimetype detection like we do in > `KUrlNavigator::Private::isCompressedPath()`. What would be the clean way to expose this function ? I wouldn't like to duplicate the

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

2018-11-30 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY When navigating in a archive file in Dolphin and then using the URL

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Thomas Surrel
thsurrel added a comment. I tried that too, but it was not working for Dolphin. It did reactivate correctly the disabled split view, but the tab was not opened, I guess we were missing an event. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:fc5a98db98a8: [KUrlNavigator] Re-activate on mouse middle button click (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46049=46155

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-11-25 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8100e99e1465: Add the possibility to have a keyboard shortcut to create a file (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-22 Thread Thomas Surrel
thsurrel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-22 Thread Thomas Surrel
thsurrel updated this revision to Diff 46049. thsurrel added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46047=46049 BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-22 Thread Thomas Surrel
thsurrel edited the summary of this revision. thsurrel edited the test plan for this revision. thsurrel added reviewers: Frameworks, elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio Cc: kde-frameworks-devel,

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-17 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R318:e710a6431160: Do not disconnect all StorageAccess signals when unmounting (authored by thsurrel). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D16913: Add the possibility to give focus to the KPluginSelector search field

2018-11-19 Thread Thomas Surrel
thsurrel added a comment. Simply calling setFocus() was not working (I used this in D16914 ). My understanding is that the widget containing this has to be completely built before trying to set the focus, adding the timer ensures that. Correct me if this

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-01-08 Thread Thomas Surrel
thsurrel added a comment. I'm on strike until my device notifier patches are reviewed ;) More seriously, I did not have the time to look into gammaray. I will as soon as I can, but don't hesitate to tell me if you want to take over this patch. REPOSITORY R295 KCMUtils REVISION DETAIL

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-11-30 Thread Thomas Surrel
thsurrel updated this revision to Diff 46589. thsurrel added a comment. Fix deleted empty line. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17270?vs=46588=46589 BRANCH arc_urlnavigatorbutton (branched from master) REVISION DETAIL

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

2018-12-01 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-03-26 Thread Thomas Surrel
thsurrel abandoned this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-03-26 Thread Thomas Surrel
thsurrel added a comment. No worries, the other patch is better actually. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-02-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 52507. thsurrel added a comment. Rebase REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=50295=52507 BRANCH arc_focussearch (branched from master) REVISION DETAIL https://phabricator.kde.org/D16913

D16913: Add the possibility to give focus to the KPluginSelector search field

2019-01-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 50295. thsurrel added a comment. Remove the timer REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=45550=50295 BRANCH arc_focussearch (branched from master) REVISION DETAIL

D16116: [KPropertiesDialog] Show a filename for the / directory

2019-05-05 Thread Thomas Surrel
thsurrel added a comment. It is still missing the '/' for me, but I am on the latest releases, not on master right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh