D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)

velurimithun added a comment. /home/veluri/ruqola_dep/kcoreaddons/autotests/kaboutdataapplicationdatatest.cpp:72: error: request for member ‘setOrganizationDomain’ in ‘aboutData2’, which is of non-class type ‘KAboutData(QLatin1String, QLatin1String, QLatin1String)’

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)

velurimithun created this revision. velurimithun added a reviewer: mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN Use QStringLiteral or QLatin1String for normal strings REPOSITORY R244 KCoreAddons BRANCH

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)

velurimithun added a comment. Errors in Kaboutdataappplicationdatatest file REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun marked an inline comment as done. velurimithun added inline comments. INLINE COMMENTS > mlaurent wrote in kaboutdatatest.cpp:184 > QStringLiteral doen't work here ? Yeah working, I'll change it > mlaurent wrote in kprocesstest.cpp:93 > QStringLiteral These strings are going as

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24197. velurimithun added a comment. Changes are made using QStringLiteral REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24175=24197 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24198. velurimithun added a comment. Update the code using QStringLiteral REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24197=24198 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. I'm getting errors in processtest!! /home/veluri/Qt/5.9.3/gcc_64/include/QtCore/qstringbuilder.h:357: error: no matching function for call to ‘QConcatenable::appendTo(const char [16], QChar*&)’ QConcatenable::appendTo(p.a, out);

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24199. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24198=24199 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES autotests/CMakeLists.txt autotests/desktoptojsontest.cpp

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun retitled this revision from "Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)" to "Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc:

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Hi!!, Code updated. Please let me know any changes are there yet to be done Regards. VM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24493. velurimithun added a comment. - Make necessary changes according to comments in https://phabricator.kde.org/D9420 Use QLatin1Char for char REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun marked 4 inline comments as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24452. velurimithun added a comment. patch created for all the changes from starting This diff contains total changes in all files... kcoreaddons compilation done!! REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added inline comments. INLINE COMMENTS > mlaurent wrote in kprocesstest.cpp:93 > ? > QStringLiteral works fine with QStringList Yeah working!!, I changed it!! But, Unable to eliminate this compile error > kstringhandlertest.cpp:45 > +expected << QLatin1String("kparts") <<

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 25076. velurimithun added a comment. - Use QString::fromUtf8(..) to decode an escape sequence like \x21 REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24493=25076 BRANCH complieWithoutRemoveDef

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun marked an inline comment as done. velurimithun added a comment. Fixed :) StringEncodings doc helped me to understand encoding and decoding. Still if there any modifications kindly let me know. Thank You. REPOSITORY

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 25712. velurimithun added a comment. - Compare license file correctly REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=25677=25712 BRANCH complieWithoutRemoveDef REVISION DETAIL

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. **Note:** In kdirwatch_qfswatch_unittest KDirWatch_UnitTest::benchNotifyWatcher() fails before and after changes in kdirwatch_unittest.cpp file REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

This revision was automatically updated to reflect the committed changes. Closed by commit R244:53f3dce3f012: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ) (authored by velurimithun). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Yeah, I have rebuilt it !! **NO ERRORS** compiling well. I'm not getting any errors like that :/ I could see few warnings but not in kaboutdatatest.cpp I'm compiling it in Qt 5.9.3 version. REPOSITORY R244 KCoreAddons REVISION DETAIL

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24238. velurimithun marked 2 inline comments as done. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24199=24238 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 24175. velurimithun added a comment. - use QLating1String REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24143=24175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun updated this revision to Diff 25677. velurimithun added a comment. - use QLating1String - compile commenting remove_definition(DQT_NO_CAST_FROM_ASCII - Make necessary changes according to comments in https://phabricator.kde.org/D9420 - Use QString::fromUtf8(..) to decode an

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Sry for the late patch :)) I was busy with setting up Ruqola... I have one doubt that why this(kdirwatch_unittest.cpp ) file is in autotests?? It should be in unit tests right? Thank You for your patience. REPOSITORY R244 KCoreAddons REVISION