Re: Review Request 125762: External extractor plugin support for KFileMetaData

stuck, and all other plugins will suffer. Perhaps the list of mimetypes supported could be in a desktop file? - Vishesh Handa On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

uld be find amazing creative uses for the data. It did not end well. - Vishesh Handa On Feb. 9, 2016, 9:09 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Please add new versions on bugs.kde.org products on KF5 releases

? > (the yaml file points to Vishesh). Whatever is easier. I am the maintainer, but I haven't been doing anything, so someone else should take over. I'll write an email announcing that soon. -- Vishesh Handa ___ Kde-frameworks-devel mailing l

Re: Find out whether a file is a remote file or not

On Sun, May 1, 2016 at 6:28 PM, Dominik Haumann wrote: > > CC: Vishesh, since maybe baloo also had to solve these issues We mostly just use Solid to query the list of mount points and ignore non local stuff. baloo/src/file/storagedevices.h -- Vishesh

Re: Review Request 115606: Ommit ontologies/ dir from installing

s wait for Ivan. - Vishesh Handa On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: let's get ready for Google Summer of Code 2014

On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: > Done: > http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for > _KIO > > Lets hope a student comes by and picks that project :) > All we need then is someone to mentor that. > Not yo

Re: Problems found by the CI system

ements are used in the CMake logic. > I've pushed a commit. That should hopefully fix it. Could you perhaps add some hook to email me about these failures? We don't have a dedicated mailing list for Baloo and I'm not sure if notifying kde- devel would b

Re: KF5 Maintainers: Please get ready for release

On Sunday, April 27, 2014 12:32:25 AM Kevin Ottens wrote: > > No maintainer: > - krunner (porting aid) I'm willing to maintain krunner. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.k

Review Request 118783: Set the normal shortcut when setting the default shortcut as well

shortcut does not actually do anything. This fixes bugs such as the brightness key not working because Powerdevil only sets the "default" shortcut. Diffs - src/kglobalaccel.cpp 54d18ec Diff: https://git.reviewboard.kde.org/r/118783/diff/

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118783/#review60209 ------- On June 16, 2014, 4:49 p.m., Vishesh Handa wrote: > > --

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

entation my understanding is that your patch is wrong > > and instead the applications need to be fixed (it's just the default as > > what one can click in the config interface, but not the loaded global > > shortcut). > > Vishesh Handa wrote: > The differen

KGlobalAccel Problems

it would look visually. Other minor Issues - KXmlGui - KShortcutEditor seems to have some fixmes for KDE5. Do we want to do fix those? Perhaps someone should go through all the frameworks and make these changes or remove the comments? -- Vishesh Handa __

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

Please add a new line - Vishesh Handa On June 20, 2014, 10:01 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

c/kglobalaccel.cpp 54d18ec Diff: https://git.reviewboard.kde.org/r/118783/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

. Description --- Title says it all Diffs (updated) - kio/kio/kmimetypechooser.cpp 616b033 Diff: http://git.reviewboard.kde.org/r/112311/diff/ Testing --- Tested by running kmimetypechoosertest, the behavior is same with or without this patch. Thanks, Vishesh Handa

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

Limited testing done. My QLocale::uiLanguages() returns "en-US" which is correctly converted to "en_US". I haven't tested it with anything else. Any tips on how I should go about testing this? Thanks, Vishesh Handa ___ Kde-f

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review38971 --- On Sept. 2, 2013, 3:13 p.m., Vishesh Handa wrote: > > -

Review Request 112940: Move all kio tests to the appropriate location

/ Testing --- All the tests pass. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

/kwidgetsaddons/tests/CMakeLists.txt a78ab21 tier1/kwidgetsaddons/tests/kmimetypechoosertest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112957/diff/ Testing --- The kmimetypechooser test works Thanks, Vishesh Handa ___ Kde-frameworks-devel

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

kmimetypechooser test works Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

one do? - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40856 --- On Sept. 26, 2013, 11:11 a.m.,

Re: Review Request 112940: Move all kio tests to the appropriate location

://git.reviewboard.kde.org/r/112940/diff/ Testing --- All the tests pass. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Removing the KFileMetadataWidget

literally will not do anything. I'm planning on removing KFileMetaDataWidget completely, and marking it as deprecated in kdelibs4. Applications which still use it (Konversation and KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api. Objections? -- Vishesh

Review Request 113077: Get Kross ready for tier3

49149 kross/ui/plugin.h kross/ui/plugin.cpp kross/ui/view.h 4241aad kross/ui/view.cpp Diff: http://git.reviewboard.kde.org/r/113077/diff/ Testing --- Some tests segfault. Some of them run. I should probably convert them into autotests. Thanks, Vishesh

Failing Tests in Kross

how to run. When Kross moves to its own git repo we should probably move the ruby and python plugin in it as well. Also, can I add a MAINTAINERS file with your name in it? -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Review Request 113154: Remove KFileMetaDataWidget and friends

Diff: http://git.reviewboard.kde.org/r/113154/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

--- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113157: Remove Nepomuk dependency from kde4support

95a092f staging/kde4support/src/kdebug.areas 2cabd98 staging/kde4support/src/kio/kfilemetainfoitem.cpp 9df2602 staging/kde4support/src/kio/kfilemetainfoitem_p.h 959fbd6 Diff: http://git.reviewboard.kde.org/r/113157/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 113077: Get Kross ready for tier3

> kross/test/testkross.js > kross/test/testkross.py > kross/test/testobject.h 5383073 > kross/test/testobject.cpp 560d88c > kross/test/unittest.es > kross/test/unittest.js > kross/test/unittest.py > kross/test/unittest.rb &

Re: Review Request 113077: Get Kross ready for tier3

m run. I should probably convert them into autotests. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

aging/kde4support/src/kio/knfotranslator.cpp 0494679 staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 Diff: http://git.reviewboard.kde.org/r/113154/diff/ Testing --- Thanks, Vishesh

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/#review41676 ------- On Oct. 10, 2013, 12:56 p.m., Vishesh Handa wrote: > > --- > This is an aut

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

es and it would be one more breakage on our > > SC promise (and one we can avoid at that). > > Kevin Ottens wrote: > Of course I meant for the removals in kde4support. The comments cleanup > in kio I'm fine with it. > > Vishesh Handa wrote: > Well, avoid

Re: Failing Tests in Kross

Minor update - Sebastian Sauer's email does not seem to be working. I've tried contacting him via twitter. Lets see. If anyone knows how to contact him, please inform me. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-framew

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

es and it would be one more breakage on our > > SC promise (and one we can avoid at that). > > Kevin Ottens wrote: > Of course I meant for the removals in kde4support. The comments cleanup > in kio I'm fine with it. > > Vishesh Handa wrote: > Well, avoid

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

/kfilemetadatawidget.h 50ddce9 Diff: http://git.reviewboard.kde.org/r/113153/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113157: Remove Nepomuk dependency from kde4support

/113157/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

c/kio/knfotranslator.cpp 0494679 staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 Diff: http://git.reviewboard.kde.org/r/113154/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frame

Re: Fwd: Failing Tests in Kross

Hey everyone I managed to contact Sebastian through his kdab email account. I've attached the response below. On Fri, Oct 18, 2013 at 3:13 AM, Sebastian Sauer wrote: > On 10/16/2013 03:15 PM, Vishesh Handa wrote: >> >> Hey Sebastian > > > Aloha Vishesh :) > >

Re: Fwd: Failing Tests in Kross

ar1, when I hacked last on it). > We'll need to find another maintainer then :/ > -- > Best regards > > Sebastian Sauer | sebastian.sa...@kdab.com | Software Engineer > KDAB (Deutschland) GmbH&Co KG, a KDAB Group company > Germany: +49-30-521325470, Sweden (HQ): +46-563-540090 > KDAB - Qt Experts - Platform-independent software solutions -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113371: Kross: Remove the KJs backened

/src/kjs/kjsscript.h f760327 staging/kross/src/kjs/kjsscript.cpp 541caf2 Diff: http://git.reviewboard.kde.org/r/113371/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113371: Kross: Remove the KJs backened

/kjsinterpreter.h be2d61a staging/kross/src/kjs/kjsinterpreter.cpp d89e42b staging/kross/src/kjs/kjsscript.h f760327 staging/kross/src/kjs/kjsscript.cpp 541caf2 Diff: http://git.reviewboard.kde.org/r/113371/diff/ Testing --- Thanks, Vishesh Handa

Review Request 113496: Move Kross from staging to tier3

--- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113496: Move Kross from staging to tier3

tier3/CMakeLists.txt 249a60b Diff: http://git.reviewboard.kde.org/r/113496/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 113821: Don't install kpagedialog_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43572 --- Ship it! I don't spot anything wrong. - Vishesh Handa

Re: Review Request 109538: port KFileMetaDataReader to QProcess

should just be marked as deprecated. Why are we porting them? We already have better alternatives in the nepomuk-widgets repository. - Vishesh Handa On March 17, 2013, 1:26 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- >

Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. > &

Fancy header policy

(/include/KDE/fancyHeaders). Do we want to continue with that? Or just install them in the specific folder. Eg - Solid headers would now be installed in include/Solid/ instead of include/KDE/Solid/ Also, dibs! -- Vishesh Handa ___ Kde-frameworks-deve

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano. - Vishesh Ha

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

discarded/moved as well. - Vishesh Handa On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: > > I was just working on the same thing. > > > > I'm not sure if we want to move this to kde4support. Can we just throw it > > away? Or would that be terribly wrong? We have a replacement in > > nepomuk-wi

Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

oard.kde.org/r/111911/diff/ Testing --- Doesn't even compile right now. With (1) it will start to compile. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111916: Port khtml_part away from kde_file.h

away from kde_file.h Diffs - khtml/khtml_part.cpp 189a98e Diff: http://git.reviewboard.kde.org/r/111916/diff/ Testing --- Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it. Thanks, Vishesh

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

Isn't predicateproperties used by kfilemetainfo? Same problem with KFileMetaInfoItem and KFileWritePlugin. - Vishesh Handa On Aug. 7, 2013, 4:23 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generat

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

else could also look at it. kio/kfile/kpropertiesdialog.cpp <http://git.reviewboard.kde.org/r/111897/#comment27625> Yes, they will need to be made into plugins. One that nepomuk can provide. @David: I think we talked about this during Akademy? - Vishesh Handa On Aug. 8, 2013,

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

ed by kde4support/src/kio/kfilemetainfo.cpp. The only reason this compiles is because Strigi is optional, but without it KFileMetaInfo will completely break. Certain application such as localize still depend on it. We cannot break it without offering an alternative. - Vishesh Handa On Aug. 9, 20

Re: Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

> On Aug. 11, 2013, 8:06 a.m., Vishesh Handa wrote: > > I'm kinda confused. > > > > Strigi is still very much required by > > kde4support/src/kio/kfilemetainfo.cpp. The only reason this compiles is > > because Strigi is optional, but without it KF

Re: Review Request 111916: Port khtml_part away from kde_file.h

this patch. I'll try to diagnose it. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111916: Port khtml_part away from kde_file.h

shesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37565 --- On Aug. 12, 2013, 9:35 a.m., Vishesh Handa wrote: > > --

Re: Review Request 111916: Port khtml_part away from kde_file.h

ry to diagnose it. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

Diffs (updated) - kioslave/ftp/ftp.cpp a0da54b Diff: http://git.reviewboard.kde.org/r/111911/diff/ Testing --- Doesn't even compile right now. With (1) it will start to compile. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing

Re: Review Request 111916: Port khtml_part away from kde_file.h

segfault with and without this patch. I'll try to diagnose it. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

ges dialog. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112288: fillApplicationLanguages: Do not add the system locale

ot;US English" gets added over 50 times. Diffs - staging/xmlgui/src/kswitchlanguagedialog_p.cpp 894f2f4 Diff: http://git.reviewboard.kde.org/r/112288/diff/ Testing --- Ran kwindowtest and compared the list of languages shown in the switch languages dialog. Thanks, Vis

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

efer. I've already implemented the default swapping one. - Vishesh ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38639

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

d compared the list of languages shown in the switch languages dialog. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

"en_US". I haven't tested it with anything else. Any tips on how I should go about testing this? Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

cale.name()); // < will return false! - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/#review38687 --- On A

Review Request 112303: KIO: Move krun tests to staging/kio

/kruntest.h PRE-CREATION staging/kio/tests/kruntest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112303/diff/ Testing --- Compiled successfully + auto tests pass Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde

What's up with KRun::runCommand?

ssExited*/, execName /*user-visible name*/, iconName, window, asn, workingDirectory); } It seems that the KProcess is created and then not used at all. The git log doesn't seem to reveal much. Could you please take look? -- Vishesh Handa __

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

_US". I haven't tested it with anything else. Any tips on how I should go about testing this? Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

tips on how I should go about testing this? Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

Diffs - kio/kio/kmimetypechooser.cpp 616b033 Diff: http://git.reviewboard.kde.org/r/112311/diff/ Testing --- Tested by running kmimetypechoosertest, the behavior is same with or without this patch. Thanks, Vishesh Handa ___ Kde

Re: Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

rd.kde.org/r/112401 Discarding this as it is no longer required. - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112292/#review38740 -

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

> On June 20, 2014, 11:17 a.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch. > > Martin Gräßlin wrote: > well let's improve directly. What do you thin

Re: Review Request 118911: Fix the connection to signal globalShortcutChanged

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118911/#review60964 --- Ship it! Seems correct. - Vishesh Handa On June 24, 2014

Review Request 118960: Add a test to print out KLauncher's autostart files

--- Added it in order to debug something. Seemed like a useful things have. Diffs - CMakeLists.txt 631b9d0 tests/CMakeLists.txt PRE-CREATION tests/autostarttest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118960/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

oks way more consistent. keduvocdocument/tests/converter.cpp <https://git.reviewboard.kde.org/r/118970/#comment42532> I'm slightly confused. You're using i18n everywhere else, but here you use translate? - Vishesh Handa On June 27

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61258 --- ping? It's just a test. - Vishesh Handa On June 26,

Re: qt5 polkit-qt-1 and kdesrc-build

On Sat, Jun 28, 2014 at 5:09 PM, Sune Vuorela wrote: > On 2014-06-27, David Faure wrote: > > > > This question is still open. We're releasing kauth as part of KF5 but > > polkit-qt-1 isn't getting released. > > > > Is there any maintainer for polkit-qt-1? > > > > For that matter, who maintains K

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

: https://git.reviewboard.kde.org/r/118960/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

be tested by running `khotnewstuff "plasmoids.knsrc"` in knewstuff/tests/. Without this patch it just blocks. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

://git.reviewboard.kde.org/r/119110/diff/ Testing --- This can be tested by running `khotnewstuff "plasmoids.knsrc"` in knewstuff/tests/. Without this patch it just blocks. Thanks, Vishesh Handa ___ Kde-frameworks-devel ma

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

x27;s so expensive about Recursive mutexes? - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61614 ----------

Re: Review Request 119155: Make the desktop containment respect minimum sizes

esult in a warning in line 264 and 265. containments/desktop/package/contents/ui/main.qml <https://git.reviewboard.kde.org/r/119155/#comment43026> ? - Vishesh Handa On July 7, 2014, 12:51 p.m., Marco Martin wrote: > > --- &g

Making KFileMetaData a framework

ave a certain number of unit tests. It's currently only used by Baloo. I would appreciate it if everyone could review the code once before it gets into frameworks. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Making KFileMetaData a framework

can be a bit expensive) > Hmm, Possibly. > > > > dump.cpp should check there's at least one arg. > (I know it's a test, but you explicitly check for >=2 but not <1) > Fixed Thanks for reviewing the code. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making KFileMetaData a framework

On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > Hello, > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > I would appreciate it if everyone could review the code once before it > > gets > > into frameworks. > > metainfo.yaml should have

Re: Making KFileMetaData a framework

data set/file against the extractors and to get some > result out of that should be made thread safe. > > Bye -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119796: Add a --run-env option

and qtdir configuration values from Module.pm. Could someone help? Diffs - modules/ksb/Application.pm 0324002 Diff: https://git.reviewboard.kde.org/r/119796/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-

Re: split kdepimlibs

definitely doesn't seem like a dumping ground. It's a valuable library that is also used by kpeople. It seems like a good candidate for an individual framework. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.o

Review Request 120049: KDirNotify: Use QUrl::toStringList

Description --- Instead of a custom function. QUrl::toStringList reserves the size of the new list before hand. Diffs - src/core/kdirnotify.cpp 14f4c9c Diff: https://git.reviewboard.kde.org/r/120049/diff/ Testing --- Thanks, Vishesh Handa

Re: Initial standalone Plasma::Package repository

> deprecated > would clash) > Just to confirm - With this, the package class in plasma-framework will now be deprecated? -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

/r/120049/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119796: Add a --run-env option

This patch does not work as I could not figure out how to get the kdedir and qtdir configuration values from Module.pm. Could someone help? Diffs - modules/ksb/Application.pm 0324002 Diff: https://git.reviewboard.kde.org/r/119796/diff/ Testing --- Thanks, Vis

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

tps://git.reviewboard.kde.org/r/120550/#comment47668> Strange indentation. - Vishesh Handa On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Baloo Framework - License Exception

share of problems with Xapian [1]. But this will take time, I'm not too keen on switching to something on a whim without proper testing. Plus, it would be a substantially large change. -- Vishesh Handa [1] https://community.kde.org/Baloo/XapianProblems _

Re: Re: Baloo Framework - License Exception

to easily swap out > Xapian > by something different I would say it's not derived work. But if Xapian is > deeply wired into Baloo I would say it's derived work. > It's not deeply wired but it is a very important component. We can easily replace Xapian if we want t

Re: Re: Baloo Framework - License Exception

s linking against Xapian is enough to make it GPL. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

  1   2   >