D23917: Use const_iterator

zzag added a comment. In D23917#530297 , @broulik wrote: > If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same Yes, however it's still a good idea to be explicit about

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > output_interface.cpp:119 > +auto rit = std::find_if(resources.constBegin(), > resources.constEnd(), [native] (const ResourceData ) { return > data.resource == native; }); > if (rit != resources.end()) { > return (*it);

D23916: Remove capture of this in lambda

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23916 To: gladhorn, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > registry.cpp:879 > }); > if (it == m_interfaces.end()) { > qCDebug(KWAYLAND_CLIENT) << "Don't have interface " << > int(interface) << "with name " << name << "and minimum version" << version; constEnd REPOSITORY R127 KWayland

D23930: Set XCB to required if building the X backend

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D23930 To: davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24002: Sort files alphabetically in cmake list

zzag added inline comments. INLINE COMMENTS > CMakeLists.txt:49-50 > shell_interface.cpp > surface_interface.cpp > subcompositor_interface.cpp > textinput_interface.cpp Open vim, select all relevant lines in visual mode, and run sort command. REPOSITORY R127 KWayland

D24003: kwaylandScanner produce version enum per class

zzag added a comment. FYI, https://phabricator.kde.org/D22362#493722 INLINE COMMENTS > generator.cpp:431 > auto it = std::find_if(m_interfaces.constBegin(), > m_interfaces.constEnd(), [] (const Interface ) { return i.isGlobal(); }); > -if (it !=

D24002: Sort files alphabetically in cmake list

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 To: gladhorn, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

zzag added inline comments. INLINE COMMENTS > test_wayland_surface.cpp:396 > > -wl_buffer *blackBuffer = *(m_shm->createBuffer(black).data()); > -auto redBuffer = m_shm->createBuffer(red); > +auto blackBufferPtr = m_shm->createBuffer(black).toStrongRef(); > +

D24014: [KWayland] Port away from deprecated API in Qt 5.14

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in test_wayland_surface.cpp:396 > The "Almost Always Auto" crowd would disagree with you, but sure, your > choice. Done. Putting auto everywhere is a

D23915: Add some docstrings

zzag added inline comments. INLINE COMMENTS > dpms.h:44 > * > + * Display Power Management Signaling allows power management for monitors. > + * Not sure that this is valid documentation for org_kde_kwin_dpms_manager because it's nothing more but a factory. > dpms_interface.h:38-41 > + *

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

zzag abandoned this revision. zzag added a comment. Okay, I see. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25184 To: zzag, #plasma Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

zzag added a comment. In D20261#443859 , @broulik wrote: > This is a bug in Quassel, a violation of the FDO spec, it should have ebeen `quassel-tray-inactive` or something See https://github.com/quassel/quassel/pull/515 REPOSITORY

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

zzag retitled this revision from "Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper" to "Define property X-Plasma-MainScript for Plasma/Wallpaper". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25184 To: zzag, #plasma Cc:

D25184: Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This commit fixes `Unknown property type for key "X-Plasma-MainScript"` warning that pops up

D25708: Don't use nullptr to flags

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > IT seems that it was a error during modernize code by using nullptr Yeah, we had the same issue with running modernize-use-nullptr over kwin's code base. REPOSITORY R127 KWayland

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added a comment. In D24663#549764 , @kossebau wrote: > @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. Hi, sorry for the late response. Yes, I think this change

D24657: Add support for _GTK_FRAME_EXTENTS

zzag removed a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

zzag added a comment. I suggest to set ColumnLimit to 0 by default and allow projects to override it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:741 > > -#ifndef KWAYLANDSERVER_NO_DEPRECATED > void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop) Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag edited reviewers, added: KWin; removed: Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin, #plasma Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

zzag added a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

zzag removed a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY _GTK_FRAME_EXTENTS is a property set by the client that specifies extents of the client-side

D24568: Provide clang-format target with a KDE Frameworks style file

zzag added inline comments. INLINE COMMENTS > dfaure wrote in clang-format.cmake:75 > typo: ternary I've been always wondering how one should break long ternary operators when writing KF code. There are several ways to do it (a) w/o breaking (BreakBeforeTernaryOperators: false) const

D24657: Add support for _GTK_FRAME_EXTENTS

zzag closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:d0b3eab864a2: [server] Make double-buffered properties in xdg-shell double-buffered (authored by zzag). CHANGED PRIOR

D24465: Use ECMGenerateExportHeader to manage deprecated API better

zzag added inline comments. INLINE COMMENTS > netwm_def.h:336-339 > /** > @deprecated has unclear meaning and is KDE-only > **/ > Override = 6, // NON STANDARD This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0)`, right?

D24629: RFC: Introduce KClockSkewNotifier class

zzag created this revision. zzag added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new class provides a way for monitoring system clock changes. This class can be

D24465: Use ECMGenerateExportHeader to manage deprecated API better

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24465 To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24629: RFC: Introduce KClockSkewNotifier class

zzag abandoned this revision. zzag added a comment. Okay REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Problems in KWayland causes by API and ABI compatibility promises

Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag added a comment. I'll merge this patch after 5.68 is tagged. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag added a comment. In D27828#621821 , @apol wrote: > Maybe producing the patch that is meant to consume this will help see what's the use for this patch. D27831 REPOSITORY R127 KWayland

D27859: [server] Expose SurfaceRole class

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This can be useful for implementing out-of-tree shell surface protocols. REPOSITORY R127

D27859: [server] Expose SurfaceRole class

zzag added a dependent revision: D27860: [server] Add some sub-surface life cycle signals. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY These signals can be very useful when one wants to monitor changes in a sub-surface tree.

D27860: [server] Add some sub-surface life cycle signals

zzag added a dependency: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27860 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag added a dependent revision: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

zzag added a dependency: D27828: [server] Introduce SurfaceInterface::boundingRect(). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new method provides a convenient way for determining the rectangle that bounds the given

D27828: [server] Introduce SurfaceInterface::boundingRect()

zzag updated this revision to Diff 76922. zzag added a comment. Add missing @since REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27828?vs=76921=76922 REVISION DETAIL https://phabricator.kde.org/D27828 AFFECTED FILES src/server/surface_interface.cpp

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > plasmawindowmanagement.cpp:363 > > +void PlasmaWindow::Private::appmenuChangedCallback(void *data, > org_kde_plasma_window *window, const char* service_name,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. Even though the patch is accepted, please do not land it yet. https://phabricator.kde.org/D27464#621521 REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added a comment. Looks good to me, but please don't land without corresponding KWin patch. INLINE COMMENTS > plasmawindowmanagement.h:700 > +/** > + * TODO: Documentation. > + **/ You missed this one. REPOSITORY R127 KWayland REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:372 > + > +Q_UNUSED(window); > +} Please move it to the top of the method and remove the semicolon. > plasmawindowmanagement.h:526-527 > > +QString applicationMenuServiceName() const; > +QString

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:85 > void setGeometry(const QRect ); > +void setApplicationMenuPaths(const QString& service, const QString& > object); > wl_resource *resourceForParent(PlasmaWindowInterface *parent, > wl_resource

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added inline comments. INLINE COMMENTS > plasma-window-management.xml:20 > > > version="10" > plasma-window-management.xml:87 > > - > + > version="10" > plasma-window-management.xml:312 > > + > + and this one should be > davidedmundson

Re: Introducing SPDX License Headers

Hi, On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote: Does this approach sound reasonable? If anybody wants to review my conversion tool and the license-header-to-SPDX-translations, I am happy for feedback! +1 It appears like the SPDX markers are not used in the source code of your

D26858: Provide an implementation for the tablet interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_tablet_interface.cpp:2 > +/ > +Copyright 2014 Martin Gräßlin > + Haven't you written

D26858: Provide an implementation for the tablet interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_tablet_interface.cpp:227 > +QCOMPARE(m_surfaces.count(), 3); > +for (SurfaceInterface* surface : m_surfaces) { > +

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

zzag updated this revision to Diff 74590. zzag added a comment. s/const QWindow/QWindow/ REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=74098=74590 BRANCH port-to-shadows-api REVISION DETAIL

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27190 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27087: Add HEIF thumbnailer

zzag edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D27087: Add HEIF thumbnailer

zzag created this revision. zzag added a reviewer: Plasma. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R320 KIO Extras BRANCH heic-thumbnailer REVISION DETAIL

D27087: Add HEIF thumbnailer

zzag updated this revision to Diff 74836. zzag added a comment. missing copyright stuff in Findlibheif.cmake REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27087?vs=74835=74836 BRANCH heic-thumbnailer REVISION DETAIL

D27087: Add HEIF thumbnailer

zzag added a comment. In D27087#604479 , @broulik wrote: > There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

D27087: Add HEIF thumbnailer

zzag added a comment. In D27087#604477 , @ngraham wrote: > Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview? No, as far as I know there is no `QImageIOHandler` for HEIF files.

D27087: Add HEIF thumbnailer

zzag abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D26858: Provide an implementation for the tablet interface

zzag accepted this revision. zzag added a subscriber: davidedmundson. zzag added a comment. This revision is now accepted and ready to land. Code-wise, this change looks good. I don't have a tablet device to test this patch so you may want to wait for a +1 from @davidedmundson. INLINE

D26960: RFC: [KWindowShadows] Check for X connection

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26960 To: broulik, #plasma, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

zzag added a comment. Looks good to me. There are still many coding style issues. I suggest to run `clang-format` over individual files in this patch and then adjust the most problematic places (I don't think there are that many). You could borrow a `.clang-format` file from

D27535: Add XdgOutputV1 version 2

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27535 To: davidedmundson, #kwin, zzag Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27538 To: dvratil, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D26633: Deprecate KWindowEffects::markAsDashboard()

This revision was automatically updated to reflect the committed changes. Closed by commit R278:181d4f31f5c7: Deprecate KWindowEffects::markAsDashboard() (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26633?vs=73440=73655 REVISION

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag marked an inline comment as done. REPOSITORY R278 KWindowSystem BRANCH deprecate-dashboard REVISION DETAIL https://phabricator.kde.org/D26633 To: zzag, #kwin, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag updated this revision to Diff 73440. zzag added a comment. Add `@deprecated since` REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26633?vs=73436=73440 BRANCH deprecate-dashboard REVISION DETAIL https://phabricator.kde.org/D26633 AFFECTED

D26633: Deprecate KWindowEffects::markAsDashboard()

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY "Support" for dashboard windows in KWin was removed long time ago. REPOSITORY R278

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 73471. zzag added a comment. Fix a typo. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=73158=73471 BRANCH kclockskewnotifier REVISION DETAIL https://phabricator.kde.org/D24629 AFFECTED FILES

D26491: [Plasma Quick] Add WaylandIntegration class

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f5f43514af0d: [Plasma Quick] Add WaylandIntegration class (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26491?vs=72969=74068#toc REPOSITORY R242 Plasma Framework

D26457: Introduce shadows API

This revision was automatically updated to reflect the committed changes. Closed by commit R278:493452e98f99: Introduce shadows API (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=74055=74060 REVISION DETAIL

D26457: Introduce shadows API

zzag updated this revision to Diff 74055. zzag added a comment. Set padding of 1 for missing borders REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73733=74055 BRANCH kwindowshadow REVISION DETAIL https://phabricator.kde.org/D26457

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

zzag updated this revision to Diff 74098. zzag added a comment. Specify the parent object REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=73010=74098 BRANCH port-to-shadows-api REVISION DETAIL

D26457: Introduce shadows API

zzag updated this revision to Diff 73728. zzag added a comment. No `noexcept` `noexcept` is a very rare thing to see in KF code so let's not deviate too much. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73352=73728 BRANCH

D26457: Introduce shadows API

zzag updated this revision to Diff 73733. zzag added a comment. Update doc. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73728=73733 BRANCH kwindowshadow REVISION DETAIL https://phabricator.kde.org/D26457 AFFECTED FILES

Updating our coding conventions and coding style for C++11

Hi, I would like to update our coding conventions https://community.kde.org/Policies/Library_Code_Policy. The auto keyword is not mentioned leading to it being a common point of contention in reviews as we can't point to a reference. I would like us to copy Qt's policy [1] for consistency:

Re: Updating our coding conventions and coding style for C++11

On 1/17/20 12:46 AM, Kai Uwe Broulik wrote: > It provides useful visual information. > > auto foo = bar(); > auto baz = I don't think that you should use auto in either case since it's not clear what type foo and baz have. Cheers, Vlad

Re: Updating our coding conventions and coding style for C++11

On 1/17/20 12:27 AM, David Faure wrote: > On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote: >> I would like us to copy Qt's policy [1] for consistency: > > OK, please do. Done. Please notice that I did not annotate auto keywords with '*'. Once we have an official pol

Re: Updating our coding conventions and coding style for C++11

On 1/16/20 7:46 PM, Kai Uwe Broulik wrote: > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > > auto *something = new MyCustomType; > auto *keyEvent = static_cast(event); > const auto myList = QStringList({QLatin1String("FooThing"), >

Re: Updating our coding conventions and coding style for C++11

On 1/16/20 7:29 PM, Vlad Zahorodnii wrote: > The common practice used in KDE seems to be: > > for (a:b) Alright, it looks like we all agree on this one, so I'm going to update the Frameworks Coding Style.

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 73158. zzag added a comment. Build with older versions of glibc. See D26553 REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=72993=73158 BRANCH kclockskewnotifier

D26457: Introduce shadows API

zzag retitled this revision from "Introduce shadow API" to "Introduce shadows API". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26457 To: zzag, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

zzag updated this revision to Diff 73352. zzag added a comment. - Make KWindowShadow a QObject subclass (for memory management) - Clarify that it is okay to call destroy() after window() had been removed - Check whether QWindow has QPlatformWindow associated with it REPOSITORY R278

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > For KWindowEffects I did put window tracking into the wayland plugin and it > improved the readability of all the client code considerably. > > I would recommend looking at doing so, especially as we

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > kwayland-integration > > 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb > > src/windowsystem/windoweffects.cpp Oh, that one...

D26457: Introduce shadow API

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new API provides a platform-independent way for setting drop-shadows on a window. X11 and

D26457: Introduce shadow API

zzag updated this revision to Diff 72880. zzag added a comment. Remove pointless default member initializers in KWindowShadowPrivate. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=72862=72880 BRANCH kwindowshadow REVISION DETAIL

D26457: Introduce shadow API

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26457 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > zzag wrote in kwindowshadow.h:201 > Oh, that one... Yeah, perhaps it will be worth to handle surface > creation/destruction in kwayland-integration. Okay, looks like it's do-able. However, we would need to call `QWidget::winId()` in

D24629: RFC: Introduce KClockSkewNotifier class

zzag reclaimed this revision. zzag added a comment. D25962 adds one usage of (K)ClockSkewNotifier in KWin. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson,

D26491: [Plasma Quick] Add WaylandIntegration class

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY It allows us to get rid of DialogShadows::plasmaShellInterface(). REPOSITORY R242 Plasma

D26491: [Plasma Quick] Add WaylandIntegration class

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

zzag updated this revision to Diff 72968. zzag added a comment. Update logs. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26491?vs=72967=72968 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26491

D26491: [Plasma Quick] Add WaylandIntegration class

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26491 To: zzag, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

zzag updated this revision to Diff 72969. zzag added a comment. Rename a function. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26491?vs=72968=72969 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26491

D24629: RFC: Introduce KClockSkewNotifier class

zzag added a comment. The KWin patch has landed. Can we proceed now? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

zzag updated this revision to Diff 72993. zzag added a comment. Rename signal. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24629?vs=67889=72993 BRANCH kclockskewnotifier REVISION DETAIL https://phabricator.kde.org/D24629 AFFECTED FILES

D26503: [WIP] [Dialog Shadows] Port to KWindowSystem shadows API

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. TEST PLAN Run `qmlscene tests/dialog.qml` REPOSITORY R242 Plasma Framework (Library) BRANCH

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

zzag retitled this revision from "[WIP] [Dialog Shadows] Port to KWindowSystem shadows API" to "[Dialog Shadows] Port to KWindowSystem shadows API". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma Cc: kde-frameworks-devel,

  1   2   >