On Saturday 21 September 2013 19:18:01 Mark wrote:
I've just created a quite complicated testcase for frameworks which uses
the new signal/slot connection syntax (since Qt 5.0) and uses a lambda as
slot. The reason i did this is so that i can keep then entire testcase
(minus the
376075541c74f56ceeeb3b640cd9b791b04d32ad
Diff: http://git.reviewboard.kde.org/r/113258/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
e0f2c74f4b935994e5d3422d8abdfa1bd955d418
tier4/kcmutils/src/ksettings/dialog.cpp
376075541c74f56ceeeb3b640cd9b791b04d32ad
Diff: http://git.reviewboard.kde.org/r/113258/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
integrated into the frameworks branch by
now (at least for the subset I have the required dependencies for).
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
/#review42130
---
On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113373
://git.reviewboard.kde.org/r/113373/diff/
Testing
---
Compiles, all required fixes have been integrated into the frameworks branch by
now (at least for the subset I have the required dependencies for).
Thanks,
Volker Krause
___
Kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113583/#review42872
---
Ship it!
Ship It!
- Volker Krause
On Nov. 2, 2013, 7:38
On Thursday 17 November 2011 16:07:19 Kevin Ottens wrote:
On Thursday 17 November 2011 15:42:48 Volker Krause wrote:
On Wednesday 16 November 2011 18:39:57 Kevin Kofler wrote:
But the problem is: At least in Qt 4.8 (I haven't checked Qt 5 yet
because browsing its submodules
On Tuesday 11 September 2012 08:12:52 Laszlo Papp wrote:
Hi,
Trying to build the kde-frameworks branch on ARM, but I am facing the issue
below. I had the impression the reduce_relocations changes in Qt5 is
managed by cmake from the version 2.8.9 which I have been using in this
environment.
On Saturday 29 December 2012 11:44:20 David Faure wrote:
On Friday 28 December 2012 02:50:53 Mark wrote:
Another thing is the UDS_EXTRA and UDS_EXTRA_END. I
seriously doubt that the functionality is even used anywhere.
Yes, this got lost with the move from the old konq views to dolphin.
On Wednesday 03 April 2013 10:09:56 Mirko Boehm wrote:
On 04/02/2013 05:05 PM, Sebastian Kügler wrote:
- - Examples are currently in the kdelibs tree, at
tier1/threadweaver/examples. I like that they are in the same
repository, but still - is this the right place?
If not, we have
---
Remove dead code.
Diffs
-
src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7
Diff: https://git.reviewboard.kde.org/r/120184/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120186/#review66415
---
On Sept. 13, 2014, 4:02 p.m., Volker Krause wrote
322d2e6e7e4dd5d049c0212da823b12cbbc48b91
Diff: https://git.reviewboard.kde.org/r/120186/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Description
---
Moves 704 bytes from .data to .rodata, ie. from per-process to shared
memory.
Diffs
-
src/kcolorscheme.cpp 666418a173b688d52c10cd0d97a6221aea078b98
Diff: https://git.reviewboard.kde.org/r/120187/diff/
Testing
---
Thanks,
Volker Krause
://git.reviewboard.kde.org/r/120200/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
937e9d40d72ea88094a412943a1291fa1c290f0e
src/job_p.cpp 4bfc7d6db278a223774f4fd849468868b2eafa6c
Diff: https://git.reviewboard.kde.org/r/120200/diff/
Testing
---
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
marked as submitted.
Review request for KDE Frameworks.
Repository: karchive
Description
---
Remove dead code.
Diffs
-
src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7
Diff: https://git.reviewboard.kde.org/r/120184/diff/
Testing
---
Thanks,
Volker Krause
offset: 32, size: 1, alignment: 1
// 7 byte(s) padding
QPluginLoader* loader; // member offset: 40, size: 8, alignment: 8
}; // size: 48, alignment: 8
```
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
://git.reviewboard.kde.org/r/122109/diff/
Testing
---
Tested and measured with the KRFPM usage in GammaRay, saves about 5% of total
application CPU cost according to callgrind.
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde
://git.reviewboard.kde.org/r/122109/#review74187
---
On Jan. 17, 2015, 5:22 p.m., Volker Krause wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-
src/krecursivefilterproxymodel.cpp 241f2e8e7e610c397bebc6608a64e4f12e570aea
Diff: https://git.reviewboard.kde.org/r/122109/diff/
Testing
---
Tested and measured with the KRFPM usage in GammaRay, saves about 5% of total
application CPU cost according to callgrind.
Thanks,
Volker
errorString; // member offset: 24, size: 8, alignment: 8
bool pluginVersionResolved; // member offset: 32, size: 1, alignment: 1
// 7 byte(s) padding
QPluginLoader* loader; // member offset: 40, size: 8, alignment: 8
}; // size: 48, alignment: 8
```
Thanks,
Volker Krause
:
https://git.reviewboard.kde.org/r/122487/#review75629
---
On Feb. 9, 2015, 5:04 p.m., Volker Krause wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Wednesday 11 February 2015 13:52:36 Thiago Jung Bauermann wrote:
Volker Krause wrote:
On Feb. 8, 2015, 8:45 p.m., David Faure wrote:
Which magic tool did you come up with this time, to detect such things?
:-)
Aleix Pol Gonzalez wrote:
+1 :D I too want to know!
It's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122487/#review79066
---
On Feb. 9, 2015, 5:04 p.m., Volker Krause wrote
QPixmap customPixmap; // member offset: 32, size: 32, alignment: 8
int spacing; // member offset: 64, size: 4, alignment: 4
// 4 byte(s) padding
}; // size: 72, alignment: 8
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123390/#review79078
---
On April 16, 2015, 7:53 p.m., Volker Krause wrote
On April 16, 2015, 8:43 p.m., Laurent Montel wrote:
Hi volker
What did you use as program to detect it ?
Thanks for info.
Volker Krause wrote:
The tool is called elf-packcheck, part of
kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as
testing ground
marked as submitted.
Review request for KDE Frameworks and Christoph Feck.
Changes
---
Submitted with commit 70e730bf57a5a47e635f8ed118ce04470649bb94 by Volker Krause
to branch master.
Repository: kwidgetsaddons
Description
---
Saves 8 byte in all cases, on 64bit systems.
Diffs
On Friday 21 August 2015 22:34:21 David Faure wrote:
On Friday 21 August 2015 08:46:28 no-re...@kde.org wrote:
TestSuite.kiofilewidgets-kfileplacesmodeltest
Nooo :-(
The QSet ordering problem is still there, even with
qputenv(QT_HASH_SEED, 0);
Does 0 instead of 0 help here?
On Friday 21 August 2015 10:53:29 Olivier Goffart wrote:
On Friday 21. August 2015 10:05:09 David Faure wrote:
Hi Olivier,
I've been trying to fix performance problems with QIcon::fromTheme(foo)
when using KIconEngine, and I'm hitting a wall due to the QIcon API - more
precisely, that
than 15% of the instructions spend in KConfig
parsing code.
Diffs
-
src/integrationplugin/ktexttohtml.cpp
604c18eed06ed76b13aa644fa762a1de6d2f3961
Diff: https://git.reviewboard.kde.org/r/124878/diff/
Testing
---
Callgrind + KMail.
Thanks,
Volker Krause
shows the correct caption now.
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit df89f647f19ad61d9075a9057adb5dc0d73dc187 by Volker Krause
to branch master.
Repository: frameworkintegration
Description
---
Also propagate window titles for folder-only file dialogs.
Diffs
On Aug. 20, 2015, 4:54 p.m., Volker Krause wrote:
Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() usage here,
hits the disk as before.
IIUC insertion into the persistent cache only happens when actually rendering
the icon, right? I am trying to debug this with KMail, my
. 19, 2015, 7:25 a.m.)
Review request for KDE Frameworks, Christoph Feck and Volker Krause.
Repository: kiconthemes
Description
---
This makes QIcon::fromTheme() much faster, for all cases where we have loaded
the
icon once before (including in another process).
Diffs
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124879/#review84187
---
Looks good to me.
- Volker Krause
On Aug. 22, 2015, 3:06
() usage here, hits
the disk as before.
- Volker Krause
On Aug. 20, 2015, 8:07 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811
On Monday 10 August 2015 14:38:34 David Faure wrote:
On Monday 10 August 2015 13:23:05 Volker Krause wrote:
Yep, and there are more reasons for not using nested classes for this and
following the Qt scheme instead, such as the Q_D/Q_Q macros for example.
Right.
For existing code
Hi,
it turns out KF5 (and PIM, which is where I started looking into this) have
quite some unintentionally exported private symbols (2000+ for PIM and the KF5
subset used by it, I'd not entirely trust the tool yet though ;) ).
This is mainly caused by using nested private classes, those
On Monday 10 August 2015 13:06:29 David Faure wrote:
On Monday 10 August 2015 11:47:43 Volker Krause wrote:
Hi,
it turns out KF5 (and PIM, which is where I started looking into this)
have
quite some unintentionally exported private symbols (2000+ for PIM and the
KF5 subset used
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 977afe65ac657f19795effae24059ac298cfe16a by Volker Krause
to branch master.
Repository: kemoticons
Description
---
This already contains a cache for the theme, and it is expensive to create
On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote:
Heya,
This is problem on Windows because the *final* installation location is not
known at compile-time (obviously software is installed via installers, users
can pick up the installation prefix). Of course this also limits the
On Thursday 27 August 2015 00:14:50 Kevin Funk wrote:
On Wednesday 26 August 2015 13:40:20 Volker Krause wrote:
On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote:
Heya,
This is problem on Windows because the *final* installation location is
not
known at compile-time
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote:
> On Tuesday 8. September 2015 10:26:20 David Faure wrote:
> > On Monday 07 September 2015 15:53:31 Olivier Goffart wrote:
> > > But the problem is that QIcon::isNull is likely to be called anyway.
> > > And this will again do all the
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 9f8b448cf45d71bb28ec4b9dd9300282a2b07d55 by Volker Krause
to branch master.
Repository: kitemmodels
Description
---
We need to disconnect from a previous source model if present, not the new
runtime warnings in GammaRay, which makes use of resetting the
source model.
Thanks,
Volker Krause
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
dbb6eba421c0e680fffe43582f210ea3e42e6e7f
Diff: https://git.reviewboard.kde.org/r/126789/diff/
Testing
---
Tested in GammaRay, where the layoutChanges are particularly painful as the
source model is in a different process.
Thanks,
Volker Krause
___
Kde
the tests.
- Volker
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126789/#review91306
---
On Jan. 18, 2016, 9:59 a.m.
Thanks for looking into this Aleix!
On Wednesday 27 April 2016 02:26:06 Aleix Pol wrote:
> Hi,
> As assessed lately, one penalty we have when starting an application
> is the icons look-up. It's not really Breeze's fault, the intersection
> of the standard we're using and how we're using it makes
On Friday 01 January 2016 18:24:17 David Faure wrote:
> On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > Hi,
> >
> > It's xmas holidays, so it must be time to poke a stick at KHolidays again
> > for inclusion as a Framework. As far as I am aware there are no
> > outstanding
> > porting
Hi,
please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
becoming a framework :)
This is a tier1/functional version of the Kate syntax highlighting engine.
It's not tied to a particular output format or editor engine, the interface is
basically just passing in a line of text
On Sunday 11 September 2016 05:33:29 Michael Palimaka wrote:
> On 11/09/16 01:47, Volker Krause wrote:
> > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> > becoming a framework :)
>
> Thanks a lot for working on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128980/#review99384
---
Ship it!
Ship It!
- Volker Krause
On Sept. 21, 2016, 3
Thanks!
On Friday 30 September 2016 10:08:27 David Faure wrote:
> On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote:
> > Hi,
> >
> > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> > becoming a framework :)
>
> Looks good. I
On Saturday 01 October 2016 21:28:54 Dominik Haumann wrote:
> On Fri, Sep 30, 2016 at 10:08 AM, David Faure <fa...@kde.org> wrote:
> > On samedi 10 septembre 2016 17:47:00 CEST Volker Krause wrote:
> >> please review KF5::SyntaxHighlighting (syntax-highlighting i
On Friday 04 November 2016 14:54:25 Volker Krause wrote:
> Hi,
>
> On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote:
> > one of the things we praise about Qt is the predictability of class names
> > and methods names. Because the patterns used with the
Hi,
On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote:
> one of the things we praise about Qt is the predictability of class names
> and methods names. Because the patterns used with them decrease the amount
> of knowledge one needs to have, as things can be derived. No need to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129795/#review101886
---
Ship it!
Ship It!
- Volker Krause
On Jan. 8, 2017, 5
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Thank you, was missing this as well :) Just one nitpick: please make the
license attribute more precise, e.g. "LGPLv2+". And if you happen to have a
file around you can share, please add
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
So far this was only accepting QGroupBoxes containing only auto-exclusive
buttons. Now we also accept QGroupBoxes that contain non-buttons,
vkrause closed this revision.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D5344
To: vkrause, dvratil, dfaure
Cc: #frameworks
vkrause added a comment.
Fair point, I'll add options for this.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D6990
To: vkrause, #frameworks, cordlandwehr
Cc: aacid
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Also, add a temporary workaround for ECM requiring lrelease/lconvert host
tools if the KF5 sources include translations (which they do
vkrause added a comment.
Any preferences on the naming? [KF5|]_[NO|USE]_[WIDGETS|GUI|...]? I'm leaning towards the _USE_ variant, on by
default obviously, to avoid double negative conditions in the code.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D6990
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R868:ee7c296202da: Make ECM a dependency for all frameworks
(authored by vkrause).
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
CHANGES SINCE LAST UPDATE
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is useful for cross-compilation, where we only need the QtCore-only
parsetrigrams build tool on the host and avoids having to pull in a full
graphics stack for the host build in Yocto.
vkrause updated this revision to Diff 17388.
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6992?vs=17387=17388
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6992
AFFECTED FILES
CMakeLists.txt
src/config-kcrash.h.cmake
src/kcrash.cpp
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6992
AFFECTED FILES
src/kcrash.cpp
To: vkrause, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:ab4e46f45e84: Allow to build Sonnet without Qt5Widgets
(authored by vkrause).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6990?vs=17513=17595
REVISION DETAIL
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
hl-cross-compile
REVISION DETAIL
https://phabricator.kde.org/D7102
AFFECTED FILES
src/indexer/CMakeLists.txt
To: vkrause, #frameworks
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This actually only builds the indexer, which is useful for
cross-compilation. With Yocto this avoids pulling in a full
graphics stack for the host build.
REPOSITORY
R216 Syntax
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
By default, Qt is built without accessibility there, which is what
would indirectly include the needed QColor with a "normal" Qt build
here.
REPOSITORY
R242 Plasma Framework (Library)
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0a8d1f9cd474: Fix compilation on Yocto (authored by
vkrause).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7117?vs=17661=17677
REVISION
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- no more hardcoded colors, which makes the source view in KMail a lot more
pleasant to look at
- reduced the regexp usage in favor of
vkrause added a task: T6716: Fix native kauth-policy-gen build for KAuth.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D7274
To: vkrause, #frameworks, cordlandwehr
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is primarily useful for cross-compilation, where e.g. with Yocto
neither Qt5Widgets nor PolicyKit are easily available for the host build.
REPOSITORY
R283 KAuth
BRANCH
pending
vkrause created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7275
AFFECTED FILES
src/view/kateviewinternal.cpp
To:
vkrause updated this revision to Diff 18105.
vkrause added a comment.
Add body context, fix some allowed characters for content boundaries and
email addresses.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7289?vs=18088=18105
BRANCH
master
vkrause marked an inline comment as done.
vkrause added inline comments.
INLINE COMMENTS
> dhaumann wrote in email.xml:51
> Not sure, but is underscore '_' also allowed?
Not here, but below indeed.
> dhaumann wrote in email.xml:52
> Search for lineEmptyContext here:
>
vkrause updated this revision to Diff 18106.
vkrause added a comment.
- improve content boundary regexp
- don't attempt to highlight unknown header content, those can contain
arbitrarily bizarrely encoded stuff (see e.g. X-Face)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST
vkrause added a comment.
Correct, any highlighting of the body content is gone, intentionally. The
original highlighting was from a time when emails had 4-5 human readable
headers and ASCII bodys. At that time body highlighting made sense, and even
reading emails in kate was feasible.
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9ef966973313: Fix build with QT_NO_ACCESSIBILITY (authored
by vkrause).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7275?vs=18056=18074
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b54210c3e238: Rewrite the email syntax definition
(authored by vkrause).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7289?vs=18106=18150#toc
REPOSITORY
R216 Syntax Highlighting
CHANGES
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6810
To: guoyunhe, #framework_syntax_hightlighting, vkrause
Cc: vkrause,
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6858
To: dhaumann, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6912
To: dhaumann, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6913
To: dhaumann, cullmann, vkrause
Cc: #frameworks
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Based on https://github.com/jgm/highlighting-kate/pull/80/ with some fixes
and improvements.
REPOSITORY
R216 Syntax Highlighting
vkrause updated this revision to Diff 17103.
vkrause added a comment.
Right, license is due to the original file.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6867?vs=17094=17103
REVISION DETAIL
https://phabricator.kde.org/D6867
AFFECTED
vkrause closed this revision.
vkrause added a comment.
Pushed to master.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
vkrause added a comment.
yep, keep the mimetype field empty in that case
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5463
To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate
Cc: vkrause, dhaumann, #frameworks
vkrause updated this revision to Diff 17727.
vkrause added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Fix homepage URL
REPOSITORY
R868 Yocto: KDE Frameworks Packaging
CHANGES SINCE LAST UPDATE
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It's not necessary, and it breaks when cross-compiling, as find_file
changes its behavior then.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R274 KIdleTime
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7154
AFFECTED FILES
CMakeLists.txt
To: vkrause, #frameworks
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Exporting the executables will make the cmake config file check for their
presence when used, which isn't really necessary, and is actually a problem
for cross-compilation, where the helper
vkrause added a comment.
I agree on this needing runtime rather than compile-time selection code. I
disagree on this not happening in reality though, the KF5 Yocto recipes assume
there is no X11, which is why I ran into this in the first place :)
REPOSITORY
R285 KCrash
REVISION DETAIL
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
1 - 100 of 1008 matches
Mail list logo
