D29223: Update Taiwanese holidays

weisi added a comment. I prefer this diff to the changes I took in D29373 . I wish I had seen this diff earlier. Would you also indicate the plan for the festivals specified as "2020" in this diff for future years? For example, could you add the 2021

D29372: Taiwan: Use "zh_TW" language code

weisi added a comment. I think the approach in D29223 (renaming the file also) is more preferred. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel,

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi added a comment. I agree with the general idea in D29223 and feel D29223 is in a better shape than this diff. However, I think some festivals referred to in this diff (not mentioned in the law - 紀念日及節日實施辦法

D29372: Taiwan: Use "zh_TW" language code

weisi added a reviewer: winterz. weisi added a comment. Adding a reviewer to this diff. Thanks! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29372: Taiwan: Use "zh_TW" language code

weisi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It was set to `tw_zh` which I think is a typo. According to Wikipedia, > `zh-TW` is the IETF language tag for the

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi updated this revision to Diff 81772. weisi added a comment. Renamed "農曆除夕" (//Lunar New Year's eve on Lunar calendar//) to "除夕" (//Lunar New Year's eve//). There's no need to specify "lunar calendar" here. REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY The previous revision put in fixed dates (month/day) for many holidays which are actually

D29223: Update Taiwanese holidays

weisi added a comment. Thanks! Looks good :) REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns,

D29372: Taiwan: Use "zh_TW" language code

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel,

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: nhiga, kde-frameworks-devel,

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

weisi created this revision. weisi added a reviewer: winterz. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It's a trivial fix, but this syntax error poped up when I was doing another holiday