[Differential] [Closed] D4288: Add Kleopatra tray icon

guoyunhe closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma, mart Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai,

[Differential] [Updated] D4289: Add VLC tray icon

guoyunhe added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma:_design, #plasma Cc: andreaska, guoyunhe, #frameworks

[Differential] [Commented On] D4495: Remove monochrome application icons

guoyunhe added a comment. Found a problem in KTorrent. But I guess we can change the icon used in KTorrent. F2426037: Spectacle.oq3409.png REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES

[Differential] [Updated, 79 lines] D4495: Remove monochrome application icons

guoyunhe removed R266 Breeze Icons as the repository for this revision. guoyunhe updated this revision to Diff 11051. guoyunhe added a comment. Remove some extra icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4495?vs=11050=11051 REVISION DETAIL

[Differential] [Updated] D4495: Remove monochrome application icons

guoyunhe updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #breeze Cc: andreaska, #frameworks

[Differential] [Request, 30 lines] D4495: Remove monochrome application icons

guoyunhe created this revision. guoyunhe added a reviewer: Breeze. guoyunhe set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY These monochrome icons cause

[Differential] [Commented On] D4252: fix brackets icon

guoyunhe added a comment. Like this REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze Cc: guoyunhe, #frameworks

[Differential] [Request, 0 lines] D4288: Add Kleopatra tray icon

guoyunhe created this revision. guoyunhe added a reviewer: Plasma. guoyunhe set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY

[Differential] [Request, 0 lines] D4289: Add VLC tray icon

guoyunhe created this revision. guoyunhe added a reviewer: Plasma: Design. guoyunhe set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY F2171236:

[Differential] [Updated] D4288: Add Kleopatra tray icon

guoyunhe updated the summary for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma Cc: plasma-devel, guoyunhe, #frameworks,

[Differential] [Commented On] D4289: Add VLC tray icon

guoyunhe added a comment. In https://phabricator.kde.org/D4289#80406, @andreaska wrote: > can you upload the svgz file cause I can't download it here. Uploaded REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES

[Differential] [Updated] D4289: Add VLC tray icon

guoyunhe updated the summary for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma:_design Cc: andreaska, guoyunhe, #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It is a modified version of SCSS syntax. Major difference is variable start with @ instead of $. It performs better with LESS' nested

D5463: Pug/Jade Syntax

guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe added reviewers: KTextEditor, Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5463: Pug/Jade Syntax

guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN F3709335: Screenshot_20170415_14.png F3709391: standard.pug

D5463: Pug/Jade Syntax

guoyunhe edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #kate, #ktexteditor, #framework_syntax_hightlighting Cc: #frameworks

D5463: Pug/Jade Syntax

guoyunhe added a comment. In https://phabricator.kde.org/D5463#102409, @dhaumann wrote: > Do you also agree to release this highlighting file under MIT license? Same for the test case you attached? Also, can we use this test case for unit testing? It is okay. I can release the

D6810: Remove "*.conf" extension rule

guoyunhe created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY *.conf is a too common file extension that was used by many other file types, like Fontconfig and Apache. Having this rule will mostly

D6810: Remove "*.conf" extension rule

guoyunhe added a comment. This should fix bug https://bugs.kde.org/show_bug.cgi?id=382520 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting Cc: #frameworks

D6810: Remove "*.conf" extension rule

guoyunhe closed this revision. guoyunhe added a comment. This patch has been committed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting, vkrause Cc: vkrause, #frameworks

D5463: Pug/Jade Syntax

guoyunhe added a comment. I found this part might be a bug in this syntax highlight: mimetype="text/plain" It will highlight all plain text file to pug syntax. Should I just change mimetype to empty? Not sure how to write it for files that don't have registered mimetype.

D5463: Pug/Jade Syntax

guoyunhe updated this revision to Diff 13734. guoyunhe added a comment. Remove mimetype REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5463?vs=13459=13734 REVISION DETAIL https://phabricator.kde.org/D5463 AFFECTED FILES

D4289: Add VLC tray icon

guoyunhe closed this revision. guoyunhe added a comment. Committed REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 To: guoyunhe, #plasma:_design, #plasma, davidedmundson Cc: andreaska, guoyunhe, #frameworks

D5463: Pug/Jade Syntax

guoyunhe added a comment. Could someone approve this patch? So I can commit it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D4289: Add VLC tray icon

guoyunhe added a comment. Any news about this icon? will it be approved? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 To: guoyunhe, #plasma:_design, #plasma Cc: andreaska, guoyunhe, #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe added a comment. They didn't include any screenshots in https://phabricator.kde.org/D5799 so I make my own: F3871416: Screenshot_20170821_113740.png The results are almost the same except text styles. Left is theirs, right is mine.

D5431: New LESS syntax based on SCSS

guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5431 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate, cullmann Cc: jtamate, gszymaszek, dhaumann, cullmann, #frameworks

D5431: New LESS syntax based on SCSS

guoyunhe added a comment. In https://phabricator.kde.org/D5431#138044, @dhaumann wrote: > Hm, just yesterday we committed https://phabricator.kde.org/D5799, which seems to do the same thing. Can you compare this and possibly update your patch? Sorry we did not notice this earlier...

D5463: Pug/Jade Syntax

guoyunhe abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

D4495: Remove monochrome application icons

guoyunhe abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D4495 To: guoyunhe, #breeze Cc: andreaska, #frameworks

D17469: applications-games icon for dark theme

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469 AFFECTED FILES

D17469: applications-games icon for dark theme

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

guoyunhe updated this revision to Diff 47251. guoyunhe added a comment. Add modified icon with light background REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47245=47251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469

D17469: applications-games icon for dark theme

guoyunhe updated this revision to Diff 47254. guoyunhe added a comment. Clean up Inkscape metadata REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47251=47254 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469 AFFECTED

D17469: applications-games icon for dark theme

guoyunhe added a comment. In D17469#374494 , @ndavis wrote: > Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54688. guoyunhe added a comment. Fix typo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54546=54688 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES .gitignore

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54918. guoyunhe added a comment. Don't use remote JavaScript library REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54688=54918 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54919. guoyunhe added a comment. Output to stderr REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54918=54919 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432348 , @bcooksley wrote: > I assume this fetches the icons from your local system? yes. it depends on text files generated by scripts, which contains list of all icons REPOSITORY R266 Breeze

D19812: Add a web page to view and compare icons of different sizes

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY This simple web page provides a table of all icons. So developers can easily know which icon size is missing, or

D19812: Add a web page to view and compare icons of different sizes

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54049. guoyunhe added a comment. Add CMake build steps for web page REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54048=54049 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432326 , @ngraham wrote: > Neato! Looks pretty handy. Two issues I found: > > - generate_web_data.sh isn't executable > - I'd like to see this run as part of the build process, so that `index.html` gets

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54051. guoyunhe added a comment. Move outside of generate_binary_resource REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54050=54051 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54048. guoyunhe added a comment. Fix data updating issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54047=54048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54050. guoyunhe added a comment. Remove unnecessary spaces REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54049=54050 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED

D17469: applications-games icon for dark theme

guoyunhe added a comment. In D17469#429992 , @ndavis wrote: > @guoyunhe Do you mind if I commandeer this? Go ahead! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432424 , @ngraham wrote: > Getting closer: > > Scanning dependencies of target generate-web > make[2]: generate_web_data.sh: Command not found > CMakeFiles/generate-web.dir/build.make:57: recipe

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#433916 , @ndavis wrote: > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? Like this? F6700542: image.png

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54257. guoyunhe added a comment. Use typical Breeze background colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54252=54257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54252. guoyunhe added a comment. Add ${CMAKE_SOURCE_DIR} prefix to script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54051=54252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#434089 , @ngraham wrote: > Thanks, it compiles with CMake now! \o/ > > I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54546. guoyunhe added a comment. Improve bash script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54535=54546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#436154 , @pino wrote: > - please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54535. guoyunhe added a comment. Add search function REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54533=54535 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54533. guoyunhe added a comment. Add color blind mode REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54532=54533 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54532. guoyunhe added a comment. Move build files to CMake build directory REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54257=54532 BRANCH master REVISION DETAIL

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. F6709477: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. The code is stable version Vue.js. Source is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.min.js Uncompiled version is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.js I used to include it from remote URL. But someone think it is not

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456869 , @ltoscano wrote: > The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read.

D19812: Add a web page to view and compare icons of different sizes

guoyunhe abandoned this revision. guoyunhe added a comment. Using a library can save a lot of time. Just like many simple web pages use jQuery, D3 , etc. I don't have the ability to write it all by hands from scratch... REPOSITORY R266 Breeze Icons

D19812: Add a web page to view and compare icons of different sizes

guoyunhe marked 5 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi all, Can you check if here is anything else that needs to be changed? Thanks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham,

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can you give some further opinion? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley,

D23161: Make media control icons outline style instead of solid style

guoyunhe added a comment. Yes, I did a search on the internet and almost all popular music app use solid play/pause/stop icon. The outline icon will look like this in JuK: F7247683: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D23161: Make media control icons outline style instead of solid style

guoyunhe updated this revision to Diff 63763. guoyunhe added a comment. 22px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23161?vs=63762=63763 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23161 AFFECTED FILES

D23161: Make media control icons outline style instead of solid style

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY In progress. If others think this is the correct way to do it, I can continue with other media control icons and all

D23161: Make media control icons outline style instead of solid style

guoyunhe edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23161 To: guoyunhe Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

guoyunhe updated this revision to Diff 63762. guoyunhe added a comment. Correct SVG format REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23161?vs=63760=63762 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23161 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

guoyunhe added a reviewer: Frameworks. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23943 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make the change password pop up sharp in HiDPI display, which is a part of kwalletd. REPOSITORY R311 KWallet

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66050. guoyunhe edited the summary of this revision. guoyunhe added a comment. Rename enablefont and disablefont icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66043=66050 BRANCH master

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. I just followed the email icons' color: check mark is black/white, disable mark is red. F7351796: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze,

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. @ndavis can you give review? thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66077. guoyunhe added a comment. Remove hardcoded colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66071=66077 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. @ndavis it looks strange when I removed the inline style F7351830: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis,

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. @GB_2 is it correct now? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66080. guoyunhe added a comment. Add inline styles REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66077=66080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66083. guoyunhe added a comment. Remove hardcoded colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66080=66083 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66067. guoyunhe added a comment. Reduce space between A and marks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66050=66067 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe updated this revision to Diff 66071. guoyunhe added a comment. Add 16px icons for font-enable and font-disable REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66067=66071 BRANCH master REVISION DETAIL

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. @ndavis, @broulik, @ngraham, I made some change. Can you have another look? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. I was asked to remove the hard code color like: `fill="currentColor"` and `fill="#da4453"`. But I see other icons have something like `style="fill:currentColor"`. Can anyone tell me correct way of applying colors? REPOSITORY R266 Breeze Icons REVISION DETAIL

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. Changed to `currentColor` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

guoyunhe added a comment. In D23942#531086 , @broulik wrote: > Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face" OK. Then need to

D23051: Make file bookmark names consistent

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Other bookmarks don't have "Files", like "Videos", "Documents". So "Audio Files" should be changed to "Audio".

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe updated this revision to Diff 67310. guoyunhe added a comment. In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games. REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D24384: Move Amusement to Games directory instead of Games > Toys

guoyunhe added a comment. In RPM package groups, **Amusement** is a top level category and **Game** is its child category. So a game can be categorized as **Amusement/Game/Other**. However, in freedesktop.org specification, **Game** is primary category. **Amusement** is secondary

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. `kf5-network.directory` has been added to `plasma-workspace`. The trouble is still here: if we land this patch and released new frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x). REPOSITORY R309 KService REVISION DETAIL

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. @ngraham @ltoscano should I create bug ticket about the dependency issue we have here? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely. In this patch, we added a new file `kf5-network.directory` in plasma-workspace and

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. Not sure who should I ping. So I posted in maillist plasma-de...@kde.org REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25564: Fix conflicts of shortcuts

guoyunhe added a reviewer: Frameworks. REPOSITORY R480 Kipi Plugins REVISION DETAIL https://phabricator.kde.org/D25564 To: guoyunhe, #frameworks

D24436: Add applications-network icon for renaming Internet category to Network

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY See D24424 REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D24436: Add applications-network icon for renaming Internet category to Network

guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24436 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

guoyunhe added a dependent revision: D24424: Create kf5-network.directory. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24436 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >