[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4797#90144, @broulik wrote:
  
  > > So changing only the theme would mean to change the svg of `ButtonStyle`, 
which is not desirable.
  >
  > Then we need to introduce new elements in `widgets/button.svg` or a new 
`widget/toolbutton.svg` for `ToolButton` which is used and falls back to the 
old behavior if not present (to not break compat with other themes). 
`QToolButton` is QtWidgets which has nothing to do with QML or Plasma styles.
  
  
  having a new svg would make it easier for fallback (would fallback to breeze 
toolbutton for old themes) even tough i like the idea of keeping a single svg 
instead and trying to give some fallback api to framesvgitem

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, mart
Cc: mart, ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4797#90142, @subdiff wrote:
  
  > In https://phabricator.kde.org/D4797#90126, @broulik wrote:
  >
  > > Design looks ok but still you can't change `ToolButtonStyle`, instead, 
the Breeze Plasma theme needs to be changed.
  >
  >
  > Sorry, I didn't quite get it the last time you mentioned it. I think I 
understand it now. You mean it will make other themes look like Breeze, when we 
insert the code in `ToolButtonStyle`, correct? But in this case take a look at 
the current `ToolButtonStyle` code: It takes `ButtonStyle`'s svg frame directly 
and uses it for its hovered/pressed state. So changing only the theme would 
mean to change the svg of `ButtonStyle`, which is not desirable.
  >
  > Also I tested it now with the Oxygen and United themes, and `QToolButton` 
has still the same flat frame line in highlight color around it when hovered 
like in Breeze, so it seems to be independent of the theme in `QToolButton` as 
well. In the Oxygen case it is though different looking in the pressed and 
checked state. Here it has a "depth" effect to it (or it's only the frame line 
getting bigger). Not sure how we can replicate that.
  
  
  It needs to have new svg theme elements (and fallback to the currently used 
prefixes if not found) would be like toolbutton-hover and toolbutton-ressed 
prefixes in the button svg (i think for the pressed one is fine to keep it 
simple and keep the normal pressed button tough)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: mart, ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Kai Uwe Broulik]

broulik added a comment.


  > So changing only the theme would mean to change the svg of `ButtonStyle`, 
which is not desirable.
  
  Then we need to introduce new elements in `widgets/button.svg` or a new 
`widget/toolbutton.svg` for `ToolButton` which is used and falls back to the 
old behavior if not present (to not break compat with other themes). 
`QToolButton` is QtWidgets which has nothing to do with QML or Plasma styles.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  > Also I tested it now with the Oxygen and United themes, and `QToolButton` 
has still the same flat frame line in highlight color around it in when hovered 
like in Breeze, so it seems to be independent of the theme in `QToolButton` as 
well. In the Oxygen case it is though different looking in the pressed and 
checked state. Here it has a "depth" effect to it (or it's only the frame line 
getting bigger). Not sure how we can replicate that.
  
  Speaking for the widgets only (QToolButton), the fact that mouse-over looks 
similar (and, if you look closely, not identical in fact) is just a coincidence.
  This is handled by the widget style and is not hard coded
  Check with fusion style for instance (namely: dolphin -style fusion)
  
  for the QML side of things I have no idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Roman Gilg]

subdiff added a comment.


  In https://phabricator.kde.org/D4797#90126, @broulik wrote:
  
  > Design looks ok but still you can't change `ToolButtonStyle`, instead, the 
Breeze Plasma theme needs to be changed.
  
  
  Sorry, I didn't quite get it the last time you mentioned it. I think I 
understand it now. You mean it will make other themes look like Breeze, when we 
insert the code in `ToolButtonStyle`, correct? But in this case take a look at 
the current `ToolButtonStyle` code: It takes `ButtonStyle`'s svg frame directly 
and uses it for its hovered/pressed state. So changing anything in the theme 
would mean to change the svg of `ButtonStyle`, which is not desirable.
  
  Also I tested it now with the Oxygen and United themes, and `QToolButton` has 
still the same flat frame line in highlight color around it in when hovered 
like in Breeze, so it seems to be independent of the theme in `QToolButton` as 
well. In the Oxygen case it is though different looking in the pressed and 
checked state. Here it has a "depth" effect to it (or it's only the frame line 
getting bigger). Not sure how we can replicate that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Kai Uwe Broulik]

broulik added a comment.


  Design looks ok but still you can't change `ToolButtonStyle`, instead, the 
Breeze Plasma theme needs to be changed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  + 1 for me. Looks good!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Kai Uwe Broulik]

broulik added a comment.


  > Would you support the idea of using the KToolBar ToolButton design for the 
QML ToolButton aswell?
  
  Good idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi Roman,
  
  > Would you support the idea of using the KToolBar ToolButton design for the 
QML ToolButton aswell? It looks way better in my opinion and it would make the 
use of tool buttons more consistent.
  
  Yes, I would support this. It would be more consistent with QWidget.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Luigi Toscano]

ltoscano added a comment.


  In https://phabricator.kde.org/D4797#90068, @subdiff wrote:
  
  > This looks weird, because painting a whole button is not a small hint for 
the user that he can interact with the element but looks more like a completely 
new independent button suddenly being created.
  
  
  As a user (but old user, ok), I never thought about this. It is just the 
button raising when it is possible to activate it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Roman Gilg]

subdiff added a comment.


  I see where you're coming from. You're right, that the rounded edges don't 
fit so well to other Plasma element. So I would try to find another design, 
because I still think the current ToolButton is ugly. Let me make it more 
clear, what I dislike about the current (flat) ToolButton design: It just takes 
the Button design for its hover/clicked state. This looks weird, because 
painting a whole button is not a small hint for the user that he can interact 
with the element but looks more like a completely new independent button 
suddenly being created.
  
  Besides that, did you notice that we have two different ToolButton designs in 
our Frameworks? The above one for QML in Plasma Frameworks and one for QWidgets 
in KToolBar. Take a look at Dolphin for example:
  
  F2616299: video3.mp4 
  
  Would you support the idea of using the KToolBar ToolButton design for the 
QML ToolButton aswell? It looks way better in my opinion and would make the use 
of tool buttons more consistent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Kai Uwe Broulik]

broulik added a comment.


  I agree with Hugo. I also never liked the faint blue press effect of buttons 
that was introduced in the Breeze revamp in 5.5 to begin with, having that as 
normal state now is a no-go for me.
  
  Also, you can't just randomly change the behavior of ToolButtonStyle, 
instead, if we were to do this, the Breeze Plasma style should be adjusted, 
introducing a dedicated widget and/or new hints if needed, instead of the 
button component.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello Roman, 
  I disagree that the current toolbutton design "doesn't fit the overall 
design". It is (to me at least) consistent with the widget style (in e.g. 
toolbars), and all the other "squarish" elements of breeze.
  
  On the contrary, I would find the new design, with its large rounding radius, 
inconsistent with the rest, since (unless i am mistaken) such a large radius is 
used nowhere else, either in the widget or the qml style. 
  So that would be a -1, sorry.
  That does not mean that the calendar plasmoid should not be fixed, to prevent 
the items overlap.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: hpereiradacosta, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol