D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Marco Martin 
mart added a comment.


  changes of this are included in D11390 , 
this should be closed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: mart, abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  The icon changes themselves are done in D11390 
. Since this patch just touches the 
opacity, +1 from me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-16 Thread Nathaniel Graham 
ngraham added a dependent revision: D11390: new icons for disconnected/disabled 
devices.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

2018-02-02 Thread Nathaniel Graham 
ngraham added a comment.


  If this is only a change for the "disconnected wifi" icon, then maybe we 
should mimic the "disconnected wired network" icon and make the color red, 
rather than fiddling with the lightness, which will never satisfy everyone (if 
this merged, I predict bug reports that say "The disconnected wifi icon looks 
almost exactly like the connected wifi icon!")

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

2018-02-02 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks @andreask. Could we also see what it looks like next to the icon with 
all bars filled, or with only a few filled? This looks better for disconnected 
ones, but without seeing those use cases, it do worry that the presentation 
becomes too muddy for weak connections.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

2018-02-02 Thread Andreas Kainz 
andreask added a comment.


  F5688471: wifi icon.png 
  top after
  
  - breeze(light)
  - breeze-dark
  
  bottom before
  
  - breeze(light)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

2018-02-02 Thread Andreas Kainz 
andreask retitled this revision from "Improve visibility of disconnected Wi-Fi 
icon" to "Improve visibility of disconnected Wi-Fi icons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart