This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:97ca9ee095cd: Introduce K_PLUGIN_CLASS_WITH_JSON
(authored by aacid).
CHANGED PRIOR TO COMMIT
https://phabricator.
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kpluginfactory.h:211
> + */
> +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile)
> K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json,
> registerP
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
arcpatch-D10333
REVISION DETAIL
https://phabricator.kde.org/D10333
To: aacid, dfaure
Cc: kossebau, apol, #frameworks, michaelh, ngraham
aacid added a comment.
In https://phabricator.kde.org/D10333#202036, @kossebau wrote:
> Makes sense to me to have a shorter version for the common case of just one
registered plugin. Less boilerplate :)
>
> Please add a note in the API dox that this macro is for the case of just
one
aacid updated this revision to Diff 26729.
aacid added a comment.
add macro to KCoreAddons_AUTOMOC_MACRO_NAMES
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10333?vs=26623&id=26729
BRANCH
arcpatch-D10333
REVISION DETAIL
https://phabricator.kde.or
kossebau added a comment.
Makes sense to me to have a shorter version for the common case of just one
registered plugin. Less boilerplate :)
Please add a note in the API dox that this macro is for the case of just one
plugin class, and link to K_PLUGIN_FACTORY_WITH_JSON for the case some
apol added a comment.
+1
I'd welcome that. I always found odd to have to invent a name that wouldn't
be required on the rest of the program.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10333
To: aacid
Cc: apol, #frameworks, michaelh, ngraham
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
Does the same as K_PLUGIN_FACTORY_WITH_JSON but saves you typing the class
name twice.
If you lo
