D10492: add 64px media icons for elisa

[Henrik Fehlauer]

rkflx added a comment.


  @astippich FWIW, I also think the current approach of using different icon 
styles per size under the same name is problematic, not only for HiDPI. More in 
D10770#213782  and D10770#215069 
. Not sure how to best approach 
fixing this, though :/
  
  Also, make sure to check out what will become 5.45 of `breeze-icons`. You 
might be in for a surprise (at least if you like fine and thin lines).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: rkflx, astippich, ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Alexander Stippich]

astippich added a comment.


  Sorry for being so late to the party, but I just found this while reading the 
Frameworks 5.44 release notes.
  First of all, I am really grateful for the new icon. Actually, it would be 
really cool if we could also get a colorized version of a "media-artist" icon, 
since we are using a monochrome one there throughout Elisa :)
  
  However, I think how the new icons are implemented here is problematic. You 
added icons with the same name as the monochrome ones, but the new ones look 
totally different. Depending on the icon size Elisa is requesting, we now get a 
different icon. This is also the reason why I created D10293 
.
  Elisa is also using some color overlay effects, which now totally brake. I 
upgraded to Frameworks 5.44, and now Elisa looks like this:
  
  F5755115: Screenshot_20180315_174420.png 

  
  F5755117: Screenshot_20180315_174431.png 

  
  The icon for the tracks view looks now out of place, and doesn't work with 
the color overlay.
  
  Again, thanks for the icons, but I think they should be implemented with 
different names, so that we must add explicit support for them in Elisa. This 
may also effect other applications similarly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: astippich, ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Nathaniel Graham]

ngraham added a comment.


  If you're going to use arc and Phabricator, wait for reviews. If you don't 
want to wait for reviews, then just push directly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask added a comment.


  cause I changed my workflow and start use arc but I wasn't interested into a 
review.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Nathaniel Graham]

ngraham added a comment.


  Why bother to ask for a review on Phabricator if you're not going to post 
screenshots so people can see your changes or wait for any reviews before 
committing? If you don't want a review, just push to master directly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10492

To: andreask
Cc: ngraham, #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6800b88f1819: add 64px media icons for elisa (authored by 
andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10492?vs=27100=27102

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh

D10492: add 64px media icons for elisa

[Andreas Kainz]

andreask created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
andreask requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10492

AFFECTED FILES
  icons-dark/actions/64/media-album-cover.svg
  icons-dark/actions/64/media-album-track.svg
  icons-dark/actions/64/view-media-playlist.svg
  icons-dark/index.theme
  icons/actions/64/media-album-cover.svg
  icons/actions/64/media-album-track.svg
  icons/actions/64/view-media-playlist.svg
  icons/index.theme

To: andreask
Cc: #frameworks, michaelh