D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas reclaimed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.
stikonas added a comment.


  Le's close it in favour of https://phabricator.kde.org/D10518

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas updated this revision to Diff 27181.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10495?vs=27106&id=27181

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  Well, basically when you click on any KF5 application (e.g. Konversation, 
KGpg, Akregator, etc...) in the system tray, nothing happens.
  This does no happen with Qt5-only programs. Clicking on system tray there 
always brings the window up.
  
  From what I can see in the code, on X11 
KWindowSystem::activateWindow(associatedWidget->winId()); raises the window
  but if I understand correctly KWindowSystem::activateWindow can never work on 
Wayland. This is clearly not what end user
  would expect.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Martin Flöser]

graesslin added a comment.


  In D10495#205811 , @stikonas wrote:
  
  > This is more to start some discussion on system tray under Wayland. I'm not 
sure myself if this should be committed. I just use this workaround locally 
until winId() works on Wayland.
  
  
  winId will never work. I cannot say much on the patch as the context is 
missing.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Wolfgang Bauer]

wbauer added a subscriber: KWin.
wbauer added a comment.


  Indeed.
  One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663
  
  I do think this should be fixed on the lower level if possible.
  
  Adding KWin as subscriber as well to hopefully get most people that have more 
insight.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  This is more to start some discussion on system tray under Wayland. I'm not 
sure myself if this should be committed. I just use this workaround locally 
until winId() works on Wayland.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas created this revision.
stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
stikonas requested review of this revision.

REVISION SUMMARY
  Currently restoring system tray does not work on Wayland.
  
  Even with this commit, the functionality is still worse than on X11 because 
clicking on system tray does not hide application window.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart