D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

meven abandoned this revision. meven added a comment. Abandoned in favor of https://phabricator.kde.org/D10663 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. Feel free to abandon the revision. Click the Add Action... pop-up menu that's above the comments box, and select "Abandon Revision." REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: dmitrio, ltoscano, ngraham, #framewo

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

meven added a comment. In D10635#209656 , @dmitrio wrote: > I have also done some work on this issue, and my solution for this includes mechanism that should avoid deletion of existing data. I have uploaded m

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

dmitrio added a comment. I have also done some work on this issue, and my solution for this includes mechanism that should avoid deletion of existing data. I have uploaded my proposal to Phabricator too — hope it will be useful. REPOSITORY R241 KIO RE

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The idea kind of makes sense, but as is, it's very dangerous, what if the destination already existed? Case 1: copy file:///dir1 to ftp://host/dir2 which already exists. Durin

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. Fixing now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ltoscano added a comment. In D10635#209216 , @ngraham wrote: > I like to use the full string since not all of our users or people browsing the bug tracker will be familiar enough with all our products and their versioning conventions to able to

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. I like to use the full string since not all of our users or people browsing the bug tracker will be familiar enough with all our products and their versioning conventions to able to map a version number to its product. Is there a technical reason why the field should

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ltoscano added a comment. FIXED-IN: 5.44 is enough. Not sure why the rules about the versioning changed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

ngraham added a comment. Thanks for the patch! For formatting guidelines, please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch In essence, put "BUG: 383764" on its own line in the Summary section, and remove it from the title. Also please put "FIXED-

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

meven created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. meven requested review of this revision. REVISION SUMMARY Add a DeleteJob for the last file that was being copied/moved when pasting or dropping a file when th