D10661: indexerconfig: Expose canBeSearched function

2018-02-22 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R293:67a84fe99a03: indexerconfig: Expose canBeSearched function (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10661?vs=27667&id=27788 REVISION DE

D10661: indexerconfig: Expose canBeSearched function

2018-02-22 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. For what it's worth, LGTM . REPOSITORY R293 Baloo BRANCH expose_canbesearched (branched from master) REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #

D10661: indexerconfig: Expose canBeSearched function

2018-02-21 Thread Michael Heidelbach
michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10661: indexerconfig: Expose canBeSearched function

2018-02-21 Thread Michael Heidelbach
michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: adridg, #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

2018-02-21 Thread Michael Heidelbach
michaelh updated this revision to Diff 27667. michaelh added a comment. - indexerconfig: Rephrase description REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10661?vs=27551&id=27667 BRANCH expose_canbesearched (branched from master) REVISION DETAIL https

D10661: indexerconfig: Expose canBeSearched function

2018-02-21 Thread Adriaan de Groot
adridg added inline comments. INLINE COMMENTS > indexerconfig.h:42 > + * Check if \p folder can be searched taking only > + * the includeFolders() into account. > + * This description says only `includeFolders()` is taken into account. The next paragraph says "should be indexed", wh

D10661: indexerconfig: Expose canBeSearched function

2018-02-19 Thread Michael Heidelbach
michaelh added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: #frameworks, michaelh

D10661: indexerconfig: Expose canBeSearched function

2018-02-19 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Dolphin. michaelh added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Make D10205 public CCBUG:3