D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski abandoned this revision. kpiwowarski added a comment. Fixed by R159:9b47babb6c41 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma,

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. The fix needs to be a bit more complex. We can not really rely on the user to fix the database. The current plan is to have kamd backup the important parts of the database from time to time, and to recreate the database when needed. I'll see whether I can roll

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski added a comment. @ivan When database is broken additionaly kactivitymanagerd is in endless loop of creating and closing processes. Each KF5 application prints to console message: "KActivities: FATAL ERROR: Failed to contact the activity manager daemon" Maybe it would be

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein added a comment. @ivan So you wrote a method that can return null, but the call sites aren't actually prepared to handle that gracefully? :) But I was waiting for your review for that context. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. @hein This is not really as simple as 'accept without a comment'. I don't mind this patch to be merged, but keep in mind that it just turns users for which plasma crashes (for which we get an explicit message as to why) into users who do not have certain parts

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks, hein Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski retitled this revision from "Fix plasmashell crash when database is broken" to "[kactivities-stats] Fix plasmashell crash when database is broken". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks