This revision was automatically updated to reflect the committed changes.
Closed by commit R246:49192654fd24: Use Locale::name() instead of
Locale::bcp47Name() (authored by vonreth).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10741?vs=27774=27907
REVISION
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
You mean "it worked in kdelibs4". This is a kdelibs4->KF5 porting issue.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10741
To: vonreth,
vonreth added a comment.
I think it never worked at all, or it worked in the kde3 days or what ever.
I think on a full blown KDE setup the defaults are never used as the system
settings provide something different.
But to be sure, all dicts I ever seen where encoded the unix way, en_US,
apol added a comment.
Wouldn't that mean that we are either breaking other systems or that it never
worked at all?
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D10741
To: vonreth, dfaure, mlaurent, kfunk, vkrause
Cc: apol, #frameworks, michaelh
vonreth added a comment.
Any feedback?
This patch is needed to make sonnet work on windows at all...
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D10741
To: vonreth, dfaure, mlaurent, kfunk, vkrause
Cc: #frameworks, michaelh
vonreth created this revision.
vonreth added reviewers: dfaure, mlaurent, kfunk, vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.
REVISION SUMMARY
bcp47Name() is encoded like "en-US"
