D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:36d42640576e: Add ECMSetupQtPluginMacroNames (authored by 
kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10749?vs=29426=29791#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10749?vs=29426=29791

REVISION DETAIL
  https://phabricator.kde.org/D10749

AFFECTED FILES
  docs/module/ECMSetupQtPluginMacroNames.rst
  modules/ECMSetupQtPluginMacroNames.cmake

To: kossebau, #build_system, #frameworks, apol
Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addECMSetupQtPluginMacroNames

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks, apol
Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D10749#225709 , @apol wrote:
  
  > LGTM
  
  
  Thanks for having had a look :)
  
  > Do you think it would be possible to come up with a test for it?
  
  Sadly no experience with cmake stuff testing and no initial idea how to write 
such tests. So would need some days of work, where I have other things more 
appealing to me :(

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM
  Do you think it would be possible to come up with a test for it?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Questions had been:
  A) names of macro and arguments okay?
  B) other/similar/related use cases which should be covered?
  C) how to design argument passing for all the arg1, arg2, arg3? Is the 
currrent approach sane or how to support someone needing some arg5?
  
  No answers all the time mapped to: current approach okay :)
  
  For usage & purpose of this macro see D11294 
, D11295 
, D11296 

  
  Also related:
  
  - intermediate non-ecm-macro-based fixes for KF5 modules by D10733 
, D10732 
, D10724 

  - related CMake issue https://gitlab.kitware.com/cmake/cmake/issues/17750
  
  Would push Monday, March 19th if no-one objects or has some comment.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh

D10749: Add ECMSetupQtPluginMacroNames

[Friedrich W . H . Kossebau]

kossebau retitled this revision from "[RFC] Add ECMSetupQtPluginMacroNames" to 
"Add ECMSetupQtPluginMacroNames".
kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10749

To: kossebau, #build_system, #frameworks
Cc: michaelh