D10764: [AppletQuickItem] Preload applet expander only if not already expanded
This revision was automatically updated to reflect the committed changes. Closed by commit R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10764?vs=27836&id=27843 REVISION DETAIL https://phabricator.kde.org/D10764 AFFECTED FILES src/plasmaquick/appletquickitem.cpp To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10764: [AppletQuickItem] Preload applet expander only if not already expanded
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10764: [AppletQuickItem] Preload applet expander only if not already expanded
lbeltrame added a comment. +1 from me, fixes the issue I had. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10764: [AppletQuickItem] Preload applet expander only if not already expanded
broulik created this revision. broulik added reviewers: Plasma, mart, lbeltrame. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY When an applet is placed on the desktop and already shows its full representation, like Weather applet, don't create the expander item. The DefaultCompactApplet shows the dialog when `plasmoid.expanded` which will be always the case and you end up with an empty window randomly showing up on startup. TEST PLAN Placed weather applet on desktop, started plasmashell, no longer got an empty window in the top left corner of the screen Verified that kickoff still has its expander preloaded REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 AFFECTED FILES src/plasmaquick/appletquickitem.cpp To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
