D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-21 Thread Phil Stefan
pstefan abandoned this revision. pstefan added a comment. Moved to D14971 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-20 Thread Nathaniel Graham
ngraham added a subscriber: gladhorn. ngraham added a comment. In D10937#311297 , @bruns wrote: > I think this works better if you actually rotate the screen: > F6203935: rotate2.png In KScreen,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-18 Thread Stefan Brüns
bruns added a comment. I think this works better if you actually rotate the screen: F6203935: rotate2.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: broulik, bruns, #vdg,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment. Sure, I can do that, but I'd like to get feedback on the final form first :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Kai Uwe Broulik
broulik added a comment. While you're at it can't you move them to plasma-framework? Having them in Breeze makes it not work with other themes and also they are only shown in the context of Plasma anyway REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment. Sorry folks for the endless period of no activity. After some talking with ngraham I removed the laptop metaphor for a much more general standalone display. Also the projection screen was swapped out. My last feedback was that the window icons were too detailed.

D10937: Retouching of Screen Layout Selection OSD Icons

2018-06-12 Thread Nathaniel Graham
ngraham added a comment. @pstefan, any update? It would be a shame to let this amazing work languish! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Stefan Brüns
bruns added a comment. Two remarks regarding the rotation icons: 1. I would remove the keyboard from the icons - you will use these with a tablet, a 2-in-1, or a pivoted external display. 2. For the large versions, rotate the content pictogram/window not by ~20 degres, but ~70

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Andres Betts
abetts added a comment. In D10937#260688 , @pstefan wrote: > In D10937#260289 , @abetts wrote: > > > In D10937#260277 , @ngraham wrote: > > > > >

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Stefan Brüns
bruns added a comment. In D10937#260688 , @pstefan wrote: > It's supposed to be a projector screen. I took the original icon metaphor to be a projector screen, so I continued with that. I think you should remove the tripod - I have not

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Phil Stefan
pstefan added a comment. In D10937#260289 , @abetts wrote: > In D10937#260277 , @ngraham wrote: > > > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Andres Betts
abetts added a comment. In D10937#260277 , @ngraham wrote: > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? I am linking these a lot. I am "almost" there with the

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, michaelh, crozbo, firef, bruns, alexeymin, skadinna,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Nathaniel Graham
ngraham added a subscriber: VDG. ngraham added a comment. Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Phil Stefan
pstefan added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Hello again, I was just wondering if there's something left I have to do now? Like some button I have to press or something. REPOSITORY R266 Breeze Icons REVISION

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-05 Thread Phil Stefan
pstefan updated this revision to Diff 31376. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10937?vs=28315=31376 REVISION DETAIL https://phabricator.kde.org/D10937 AFFECTED FILES icons-dark/applets/128/osd-duplicate.svg

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Nathaniel Graham
ngraham added a comment. In D10937#240070 , @pstefan wrote: > I am glad you like them :) > > I will hand in the updated diff tomorrow. The color fix script somehow ate my icons and I have to restore them from a backup. You can

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Andres Betts
abetts added a comment. I don't have any objections. Good work! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Phil Stefan
pstefan added a comment. I am glad you like them :) I will hand in the updated diff tomorrow. The color fix script somehow ate my icons and I have to restore them from a backup. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze,

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Heh, I don't think anyone is ever going to want to use 16x16 versions of these in the first place, so I can live with that. These icons look fantastic. Big +1 from me. Any other

D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Phil Stefan
pstefan added a comment. Latest revision: F5787871: pls_assess.png I moved the window a bit up while maintaining the alignment, as requested. I had to remove the stand of the projector screen tho. Originally I "cheated" and moved the stand

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. In D10937#227537 , @pstefan wrote: > In D10937#227525 , @ngraham wrote: > > > Those all look pretty great to me, honestly. A nice upgrade from the current icons. > > >

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan
pstefan added a comment. In D10937#227525 , @ngraham wrote: > Those all look pretty great to me, honestly. A nice upgrade from the current icons. > > For the pink column, does it look bad if you raise the projection screen so that it's only

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Emirald Mateli
emateli added a comment. Hi, while I do appreciate the icons I also have a question: Why the use of laptop and projector over of two simple generic screens. Wouldn't that be better for all use cases? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To:

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham
ngraham added a comment. Those all look pretty great to me, honestly. A nice upgrade from the current icons. For the pink column, does it look bad if you raise the projection screen so that it's only a little bit higher than the laptop on the large icons? It seems like there's room to

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan
pstefan added a comment. An update: F5756024: thick_or_Thipng.png Green column: I still haven't found a better metaphor. With the slightly rotated window metaphors to its sides I can just leave out the window at smaller sizes, but I can't

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Andres Betts
abetts added a comment. Is there a way that we can add extra clarity by adding a label below the icons? A label that explains what the action is? I agree that the current symbolism can be hard to read but it is also very simple. If you make the connection to label, it will be even stronger

D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Nathaniel Graham
ngraham added a comment. Thanks for this patch! I like that the laptop and projector screen icons look better with your versions and don't have line weights that are as thick, which returns the focus to the icons that they're displaying. And I like that the arrows now have appropriate