D11091: Support Atlas textures in FadingNode
This revision was automatically updated to reflect the committed changes. Closed by commit R242:02c419453462: Support Atlas textures in FadingNode (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11091?vs=28809&id=28823 REVISION DETAIL https://phabricator.kde.org/D11091 AFFECTED FILES src/declarativeimports/core/fadingmaterial.frag src/declarativeimports/core/fadingmaterial_core.frag src/declarativeimports/core/fadingnode.cpp src/declarativeimports/core/iconitem.cpp To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh
D11091: Support Atlas textures in FadingNode
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D11091 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh
D11091: Support Atlas textures in FadingNode
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY Previously IconItem would create icons in new textures for animating. By keeping them in the atlas not only do we avoid that, but we should implicitly share the QSGTexture used for non-animating item. TEST PLAN Moused over icon, it changed correctly Set core profile, moused over an icon it changed correctly REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D11091 AFFECTED FILES src/declarativeimports/core/fadingmaterial.frag src/declarativeimports/core/fadingmaterial_core.frag src/declarativeimports/core/fadingnode.cpp src/declarativeimports/core/iconitem.cpp To: davidedmundson, #plasma Cc: #frameworks, michaelh
