D11099: Fix compilation on Android
vkrause abandoned this revision. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D11099 To: vkrause, #frameworks Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns
D11099: Fix compilation on Android
vkrause added a comment. I also needed API level 21 to make this work, but this changes seemed necessary independent of that, and matches what the above method does for KSDC_TIMEOUTS_SUPPORTED. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D11099 To: vkrause, #frameworks Cc: apol, michaelh
D11099: Fix compilation on Android
apol added a comment.
I actually hit this issue this week (you can see build.kde.org failing
earlier this week:
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/
I fixed it by using android-21 as the sdk version, maybe it's a more
acceptable compromise?
I'm not sure what we are compromising over though.
INLINE COMMENTS
> kshareddatacache_p.h:405
> if (timeoutsSupported) {
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
> tempLock = QSharedPointer(new
> semaphoreTimedLock(tempSemaphore));
There's a weird whitespace here.
> kshareddatacache_p.h:406
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
> tempLock = QSharedPointer(new
> semaphoreTimedLock(tempSemaphore));
> +#endif
#else Q_UNREACHABLE?
Or what happens?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D11099
To: vkrause, #frameworks
Cc: apol, michaelh
D11099: Fix compilation on Android
vkrause created this revision. vkrause added a reviewer: Frameworks. Restricted Application added a project: Frameworks. vkrause requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D11099 AFFECTED FILES src/lib/caching/kshareddatacache_p.h To: vkrause, #frameworks Cc: michaelh
