D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

2018-03-07 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:0182bc404807: Add X-KDE-OnlyShowOnQtPlatforms to KCModule 
servicetype definition (authored by kossebau).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11125?vs=28932=28939

REVISION DETAIL
  https://phabricator.kde.org/D11125

AFFECTED FILES
  src/kcmodule.desktop

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh


D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

2018-03-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11125

To: kossebau, #plasma, mart, apol
Cc: #frameworks, michaelh


D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

2018-03-07 Thread Friedrich W . H . Kossebau
kossebau added a comment.


  And seems there is also code for handling X-KDE-NotShowOnQtPlatforms in 
`KService::showOnCurrentPlatform()` (but not in kded custom code).
  lxr.kde.org tells that method is used by
  
  - plasma-phone-components/containments/homescreen/applicationlistmodel.cpp -> 
seems to use it as custom key extension to "Application" type, so would need 
custom documentation, ignoring for now
  - powerdevil/daemon/powerdevilactionpool.cpp -> PowerDevil/Action 
servicetype, without any definition, though also no service plugins found, 
ignoring for now
  
  Just mentioning for completeness, perhaps interesting to someone.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D11125

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh


D11125: Add X-KDE-OnlyShowOnQtPlatforms to KCModule servicetype definition

2018-03-07 Thread Friedrich W . H . Kossebau
kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  KCoreAddons' DesktopFileParser needs a definition of the types of all
  possible entries to do a proper conversion to JSON types.
  It is also nicer for plugin developers to have that type documented.

REPOSITORY
  R295 KCMUtils

BRANCH
  addmissingdefinitionX-KDE-OnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11125

AFFECTED FILES
  src/kcmodule.desktop

To: kossebau, #plasma, mart
Cc: #frameworks, michaelh