D11137: overflow-menu as view-more-symbolic, and horizontal
ngraham added a comment. This change broke the CI: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/ [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o ./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" /> ^ ./icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" /> ^ ./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix inkscape for connector-curvature on path is not defined sodipodi:nodetypes="ccc" /> ^ ./icons/actions/symbolic/view-more-horizontal-symbolic.svg:16: namespace error : Namespace prefix sodipodi for nodetypes on path is not defined sodipodi:nodetypes="ccc" /> ^ REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg, andreaska Cc: ngraham, Fuchs, #frameworks, michaelh, bruns
D11137: overflow-menu as view-more-symbolic, and horizontal
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b518d06b25c2: overflow-menu as view-more-symbolic, and horizontal (authored by mart). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11137?vs=28967=32786 REVISION DETAIL https://phabricator.kde.org/D11137 AFFECTED FILES icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg icons-dark/actions/symbolic/view-more-symbolic.svg icons/actions/symbolic/view-more-horizontal-symbolic.svg icons/actions/symbolic/view-more-symbolic.svg To: mart, #vdg, andreaska Cc: Fuchs, #frameworks, michaelh, bruns
D11137: overflow-menu as view-more-symbolic, and horizontal
andreaska accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH phab/overflow REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg, andreaska Cc: Fuchs, #frameworks, michaelh, ngraham, bruns
D11137: overflow-menu as view-more-symbolic, and horizontal
Fuchs added a comment. Yes, I very much like the overflow and the usage you describe, as per the discussion on Telegram and https://phabricator.kde.org/D11231, I think mixer is however not an example where it should be used, because in the mixer it's not an overflow of functionality, but rather a menu on its own. So +1 for this request here, the change on the mixer I'd -1 though. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg Cc: Fuchs, #frameworks, michaelh
D11137: overflow-menu as view-more-symbolic, and horizontal
mart changed the visibility from "No One" to "Public (No Login Required)". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg Cc: #frameworks, michaelh
D11137: overflow-menu as view-more-symbolic, and horizontal
mart created this revision. mart added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY use the 3 dots icons as view-more-symbolic, as traditionally in the iconography of most systems those are for menus of actions that didn't fit in a toolbar (as the overflow-menu name tells) while the 3 lines one means the main menu of an application and should always appear at most in a single place in a whole app this makes it less confusing as users will use our apps together apps written in other toolkits, web pages where this is common as well, as well apps on their phones which will all use this paradigm. adapt the horizontal version too, to look like what firefox uses tough i would make it black as well, as now it may always look disabled TEST PLAN shown the mixer applet (which will need its own rr) which looks lighter and causes less confusion between the global panel menu icon and the little overflow menus of the mixer items REPOSITORY R266 Breeze Icons BRANCH phab/overflow REVISION DETAIL https://phabricator.kde.org/D11137 AFFECTED FILES icons-dark/actions/symbolic/view-more-horizontal-symbolic.svg icons-dark/actions/symbolic/view-more-symbolic.svg icons/actions/symbolic/view-more-horizontal-symbolic.svg icons/actions/symbolic/view-more-symbolic.svg To: mart, #vdg Cc: #frameworks, michaelh
