D11226: autotests: Restructure

2018-03-11 Thread Michael Heidelbach 
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:b21a2ceeef83: autotests: Restructure (authored by 
michaelh).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11226?vs=29219&id=29222

REVISION DETAIL
  https://phabricator.kde.org/D11226

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/config.h.in
  autotests/extractortest.cpp
  autotests/filemetadataitemcounttest.cpp
  autotests/filemetadatawidgettest.cpp
  autotests/samplefiles/test.mp3
  autotests/samplefiles/testtagged.m4a
  autotests/samplefiles/testtagged.mp3
  autotests/test.mp3
  autotests/testtagged.m4a
  autotests/testtagged.mp3

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11226: autotests: Restructure

2018-03-11 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  In D11226#223088 , @michaelh wrote:
  
  > In D11226#223085 , 
@elvisangelaccio wrote:
  >
  > > Doesn't build here:
  > >
  > >   ../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' 
file not found
  > >
  >
  >
  > I wonder why it compiled here? 
  >  Edit: Should I more often `make clean`?
  
  
  That's a good idea if you are changing something in the build system ;)

REPOSITORY
  R824 Baloo Widgets

BRANCH
  tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11226

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11226: autotests: Restructure

2018-03-11 Thread Michael Heidelbach 
michaelh added a comment.


  In D11226#223085 , 
@elvisangelaccio wrote:
  
  > Doesn't build here:
  >
  >   ../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' 
file not found
  >
  
  
  I wonder why it compiled here?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11226

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11226: autotests: Restructure

2018-03-11 Thread Michael Heidelbach 
michaelh updated this revision to Diff 29219.
michaelh added a comment.


  - autotests: Remove obsolete includes

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11226?vs=29215&id=29219

BRANCH
  tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11226

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/config.h.in
  autotests/extractortest.cpp
  autotests/filemetadataitemcounttest.cpp
  autotests/filemetadatawidgettest.cpp
  autotests/samplefiles/test.mp3
  autotests/samplefiles/testtagged.m4a
  autotests/samplefiles/testtagged.mp3
  autotests/test.mp3
  autotests/testtagged.m4a
  autotests/testtagged.mp3

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11226: autotests: Restructure

2018-03-11 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Doesn't build here:
  
../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file 
not found

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11226

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11226: autotests: Restructure

2018-03-11 Thread Michael Heidelbach 
michaelh created this revision.
michaelh added reviewers: elvisangelaccio, Baloo, Frameworks.
Restricted Application added a project: Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  Move sample files to own folder
  Use QFINDTESTDATA for extractortest

TEST PLAN
  make test

REPOSITORY
  R824 Baloo Widgets

BRANCH
  tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11226

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/config.h.in
  autotests/extractortest.cpp
  autotests/filemetadataitemcounttest.cpp
  autotests/filemetadatawidgettest.cpp
  autotests/samplefiles/test.mp3
  autotests/samplefiles/testtagged.m4a
  autotests/samplefiles/testtagged.mp3
  autotests/test.mp3
  autotests/testtagged.m4a
  autotests/testtagged.mp3

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin