D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:43396e0a9773: Optimize many syntax highlighting files and fix the '/' char of SQL (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11543?vs=31565&id=39719#toc REPOSITORY

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-08-13 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Thanks, changes look, please comm

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-04-07 Thread Nibaldo González
nibags updated this revision to Diff 31565. nibags added a comment. - xharbour.xml is restored I have verified that the `Int` rule is not equivalent to `` REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11543?vs=30172&id=31565 BRANCH opti

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags updated this revision to Diff 30172. nibags added a comment. Some changes are undone: - **prolog.xml** : Remove fallthrought, it goes back to RegExpr [1 context]. Use kateversion 3.4. - **rpmspec.xml** : All changes are undone: remove fallthrought [4 contexts]. Use kateversion 2

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags added a comment. Then, in such a case, it would be better to make only conservative changes such as: - Change StringDetect to DetectChar or Detect2Chars. - Change AnyChar for DetectChar. - Change RegExpr for StringDetect, DetectChar or Detect2Chars. It would be better to u

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Cool! The patch already looks pretty good. Please address or comment on my questions. And for a final round, I would like to have a review by another reviewer, since this

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11543 To: nibags, #framework_syntax_highlighting Cc: #frameworks, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11543 To: nibags, #framework_syntax_highlighting Cc: #frameworks, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags edited the summary of this revision. nibags added a reviewer: Framework: Syntax Highlighting. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11543 To: nibags, #framework_syntax_highlighting Cc: #

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-03-21 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Some suggested optimizations of D10621 . **Note:**