D11583: Add platform detection and adjustment to kded

[Martin Flöser]

graesslin added a comment.


  Btw could someone please push for me. I'm not around the next two weeks

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

To: graesslin, #frameworks, #plasma, apol, romangg
Cc: michaelh, ngraham, bruns

D11583: Add platform detection and adjustment to kded

[Martin Flöser]

graesslin added a comment.


  In D11583#241314 , @apol wrote:
  
  > I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise 
is that this won't be a problem with Qt 5.11, right?
  
  
  Let's wait for it to happen, then we can still ifdef

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

To: graesslin, #frameworks, #plasma, apol, romangg
Cc: michaelh, ngraham, bruns

D11583: Add platform detection and adjustment to kded

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise 
is that this won't be a problem with Qt 5.11, right?

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

To: graesslin, #frameworks, #plasma, apol, romangg
Cc: michaelh, ngraham, bruns

D11583: Add platform detection and adjustment to kded

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

To: graesslin, #frameworks, #plasma, apol, romangg
Cc: michaelh, ngraham

D11583: Add platform detection and adjustment to kded

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma, apol.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.

REVISION SUMMARY
  Current Plasma/master branch does no longer set the QT_QPA_PLATFORM env
  variable on Wayland. As kded is a process tightly connected to the
  workspace it also needs to pick wayland QPA in a Wayland session. This
  change brings in the adjustment from plasma-workspace and ensures that
  kded works correctly on any Wayland desktop environment, being it
  Plasma, GNOME or Weston.

TEST PLAN
  Restarted session, kscreen got layout correctly

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

AFFECTED FILES
  src/kded.cpp

To: graesslin, #frameworks, #plasma, apol
Cc: michaelh, ngraham