D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR
This revision was automatically updated to reflect the committed changes. Closed by commit R290:ee1ea06d964c: use KDE_INSTALL_DATADIR instead of FULL_DATADIR (authored by bshah, committed by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11675?vs=30487&id=32610#toc REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11675?vs=30487&id=32610 REVISION DETAIL https://phabricator.kde.org/D11675 AFFECTED FILES KF5PackageMacros.cmake To: bshah, kossebau Cc: #frameworks, michaelh, bruns
D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. If no-one else can be bothered, here my shipit. REPOSITORY R290 KPackage BRANCH usedatadir REVISION DETAIL https://phabricator.kde.org/D11675 To: bshah, kossebau Cc: #frameworks, michaelh, ngraham, bruns
D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR
kossebau added a comment. While myself I have never made use of it, the idea of using a relative path & not an absolute path with the DESTINATION argument is to allow overriding the install prefix at install time. Or in words of https://cmake.org/cmake/help/v3.0/command/install.html sa > If a relative path is given it is interpreted relative to the value of the CMAKE_INSTALL_PREFIX variable. The prefix can be relocated at install time using the DESTDIR mechanism explained in the CMAKE_INSTALL_PREFIX variable documentation. So given all the other install macros I have seen allow to do that, let's be consistent here and use the relative path as well. I am not aware of any need to use the absolute path here directly. Not tested though due to broken setup currently, so just +1 and no shipit :) REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11675 To: bshah, kossebau Cc: #frameworks, michaelh, ngraham
D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR
bshah created this revision. bshah added a reviewer: kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY This is inline with other install statements REPOSITORY R290 KPackage BRANCH usedatadir REVISION DETAIL https://phabricator.kde.org/D11675 AFFECTED FILES KF5PackageMacros.cmake To: bshah, kossebau Cc: #frameworks, michaelh, ngraham
