This revision was automatically updated to reflect the committed changes.
Closed by commit R293:116e55a2076e: Handle adjacent special characters
correctly (authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11888?vs=31636&id=31681
REVISION DETAI
michaelh accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
t3
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
michaelh accepted this revision as: michaelh.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns removed a task: T3: Add string "Your system default" to translation.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns updated this revision to Diff 31636.
bruns added a task: T3: Add string "Your system default" to translation.
bruns added a comment.
rebase
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11888?vs=31550&id=31636
BRANCH
t3
REVISION DETAIL
https://ph
bruns added a dependent revision: D12037: Immediately apply termInConstruction
when term is complete.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns edited the test plan for this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns added a dependency: D12007: Add test case for parsing of double opening
'(('.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns marked 6 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
alexeymin
bruns updated this revision to Diff 31550.
bruns added a comment.
token.size() > 0 -> !token.isEmpty()
renamed tokens to tokenList
Use testcase
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11888?vs=31161&id=31550
BRANCH
b#392620_fix_operator_evalu
michaelh added a comment.
Apart from `QLatin1Char` and `token.isEmpty()` we're done, I think.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
bruns marked 8 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11888
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
michaelh added inline comments.
INLINE COMMENTS
> bruns wrote in advancedqueryparser.cpp:69
> > I don't understand. token is QString. Why not instead of switch
> > (token.at(0).toLatin1())
> >
> > switch (token) {
> > case '>'`: comparator = Term::Greater; break;
> > case '>='`: comparato
bruns added inline comments.
INLINE COMMENTS
> michaelh wrote in advancedqueryparser.cpp:69
> 1. I misunderstood your description as ':=' should become '='.
>
> > The lexer should not handle ">" and ">=" differently, both are (valid)
> > tokens, and should be returned as such.
>
> That is what
michaelh added inline comments.
INLINE COMMENTS
> bruns wrote in advancedqueryparser.cpp:55
> Why choose a different wording here? Also, the important aspect here is the
> "end", which commits the current token to the list.
Because of opening and closing parentheses, but you're right 'end' is t
bruns added inline comments.
INLINE COMMENTS
> michaelh wrote in advancedqueryparser.cpp:55
> // Parentheses delimit tokens, and are tokens by themselves
Why choose a different wording here? Also, the important aspect here is the
"end", which commits the current token to the list.
> michaelh w
michaelh requested changes to this revision.
michaelh added a comment.
This revision now requires changes to proceed.
It would be great if you could add tests for `==`, `:=` and `((...)...)` to
`autotests/unit/lib/advancedqueryparsertest.cpp`
INLINE COMMENTS
> advancedqueryparser.cpp:35
>
bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.
REVISION SUMMARY
The code handled sequences like '((' incorrectly, i.e. t
18 matches
Mail list logo
