D11924: Add "SkipSwitcher" to API

2019-03-05 Thread Vlad Zagorodniy 
zzag added a comment.


  @dfaure cc765bfb3f90a52410cbc0d2324de121cdffda61 


REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: zzag, dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, 
michaelh, bruns

D11924: Add "SkipSwitcher" to API

2019-03-04 Thread Vlad Zagorodniy 
zzag added a comment.


  @dfaure I'll take a look into this issue.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: zzag, dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, 
michaelh, bruns

D11924: Add "SkipSwitcher" to API

2019-03-02 Thread David Faure 
dfaure added a comment.


  Ping? CI is still broken by this skipSwitcher stuff.
  
  
https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/6/testReport/projectroot/autotests/kwindowsystem_kwindowinfox11test/
  
FAIL!  : KWindowInfoX11Test::testState(skipSwitcher) Compared values are 
not the same
   Actual   (int(info3.state())): 0
   Expected (int(state)): 4096
   Loc: [/home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 
SUSEQt5.10/autotests/kwindowinfox11test.cpp(230)]

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, michaelh, 
bruns

D11924: Add "SkipSwitcher" to API

2018-08-03 Thread David Faure 
dfaure added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  The CI for kwindowsystem fails ever since this was committed, can somebody 
please take a look?
  
  
https://build.kde.org/view/Frameworks/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/34/testReport/junit/(root)/TestSuite/kwindowsystem_kwindowinfox11test/
  
  FAIL!  : KWindowInfoX11Test::testState(skipSwitcher) Compared values are not 
the same
  
Loc: [/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5 
SUSEQt5.10/autotests/kwindowinfox11test.cpp(230)]

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, michaelh, 
bruns, #frameworks

D11924: Add "SkipSwitcher" to API

2018-04-19 Thread Scott Harvey 
sharvey added a subscriber: Plasma.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: #plasma, ngraham, graesslin, apol, #frameworks, michaelh, bruns

D11924: Add "SkipSwitcher" to API

2018-04-05 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:6178ab9b4006: Add SkipSwitcher to API 
(authored by sharvey, committed by ngraham).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31330=31459

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

2018-04-05 Thread Nathaniel Graham 
ngraham added a comment.


  Ok, doing it now.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

2018-04-05 Thread Martin Flöser 
graesslin added a comment.


  In D11924#240631 , @ngraham wrote:
  
  > Martin, @sharvey does not yet have commit access. Would you like to land 
this patch for him, or should I?
  
  
  Please push, I probably won't get to it the next two weeks.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

2018-04-05 Thread Nathaniel Graham 
ngraham added a comment.


  Martin, @sharvey does not yet have commit access. Would you like to land this 
patch for him, or should I?

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey added a comment.


  Thanks, @graesslin. I enjoyed this challenge.
  
  I removed the `[WIP]` tag from the title.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add 
"SkipSwitcher" to API".

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh