D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-19 Thread Nibaldo González
nibags updated this revision to Diff 32563. nibags added a comment. - Restore keywords REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs=32260&id=32563 BRANCH opt-apparmor-selinux (branched from master) REVISION DETAIL https://phabri

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-16 Thread Nibaldo González
nibags added a comment. I thought it would be better if the keywords used fewer lines in the file. If it's more comfortable I can restore it to how it was before... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann Cc: #framewor

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-16 Thread Nibaldo González
nibags updated this revision to Diff 32260. nibags added a comment. - SELinux CIL: Add binaries and float. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs=32240&id=32260 BRANCH opt-apparmor-selinux (branched from master) REVISION DET

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-16 Thread Dominik Haumann
dhaumann added a comment. Out of curiosity: why are you putting multiple items in the same line on the keyword lists? This bloats up the diff and makes a real review so much harder... :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags,

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-15 Thread Nibaldo González
nibags updated this revision to Diff 32240. nibags added a comment. - AppArmor 2.13.0 Released: allow 'if exists' in Include rules REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs=31359&id=32240 BRANCH opt-apparmor-selinux (branched fr

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-05 Thread Nibaldo González
nibags added a reviewer: dhaumann. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann Cc: #frameworks, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D11945: Optimize AppArmor & SELinux highlighting and improve regex

2018-04-05 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Some optimizations are made (some suggested from D10621 ) and o