D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. @Kai-Uwe, you can drop this merge request, given that D23758 is in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, mi

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. My version is up at D23758 INLINE COMMENTS > copyjob.cpp:2097 > +// which is why we're passing m_currentSrcURL instead of > m_current

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. I'm working on it. Unittest done, now looking into potentially better fix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

ngraham added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Ping, any update on this? @dfaure, could you lend a hand maybe, when you have some time? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-d

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. This calls for unittests. UndoManager has unittests here in kio, but if this requires kio_desktop then the test needs to be where kio_desktop is. INLINE COMMENTS > copyjob.cpp:2095 > ++m_processedFiles; > -emit q->copyingDone(q, *m_currentStatSrc, >

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

broulik added a comment. There's still something borked with it. It works once for a new file but when I undo, delete and undo again it breaks or sometimes still doesn't work at all. :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfa

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY In case of `desktop:/` KIO which rewrites URLs, looking up the URL the trashed file got didn't work. This