D11998: Ensure that the model is set when resetResizing is called

2018-04-07 Thread Fabian Kosmale 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bff960d67162: Ensure that the model is set when 
resetResizing is called (authored by fabiank).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11998?vs=31525&id=31578

REVISION DETAIL
  https://phabricator.kde.org/D11998

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-07 Thread David Faure 
dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.


  I'm not familiar with the issue but the patch makes 100% sense.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Confirmed that this fixes the issue, and it makes sense, code-wise. I did not 
see any resizing-related regressions.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale 
fabiank added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale 
fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.

REVISION SUMMARY
  Previously, KDirOperatorDetailView::setModel called resetResizing before
  QTreeView::setModel was called. Thus, when resetResizing called model()
  to obtain the model, it was still nullptr, leading to the following
  warning: "QObject::connect: invalid null parameter"
  
  As nothing we do in KDirOperatorDetailView::setModel depends on the
  model not being set yet, we simply move the call to
  KDirOperatorDetailView::setModel to the beginning of the method, to
  ensure that model() returns the new model

TEST PLAN
  Run any application which uses the KDE file dialog. Start opening a file, then
  switch the file dialog to the detailed or detailed tree mode. Without the 
patch,
  the warning should appear. Applying the patch removes the warning.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: fabiank
Cc: #frameworks, michaelh, ngraham, bruns