D12051: [UDisks] Correct handling of removable file systems
This revision was automatically updated to reflect the committed changes. Closed by commit R245:122a6cd8989a: [UDisks] Correct handling of removable file systems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12051?vs=31696=31712 REVISION DETAIL https://phabricator.kde.org/D12051 AFFECTED FILES src/solid/devices/backends/udisks2/udisksstorageaccess.cpp To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns
D12051: [UDisks] Correct handling of removable file systems
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the automount issue for me. +1 for making the code clearer, too. REPOSITORY R245 Solid BRANCH revert_empty_filepath_check REVISION DETAIL https://phabricator.kde.org/D12051 To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns
D12051: [UDisks] Correct handling of removable file systems
bruns added a dependency: D12050: Make automounting work even if StorageAccess is ignored. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12051 To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns
D12051: [UDisks] Correct handling of removable file systems
bruns created this revision. bruns added reviewers: ngraham, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Filesystems which have no fstab entry have an empty filepath (aka mountpoint), but these should be mountable nevertheless. The StorageAccess.ignored flag should only be used as a hint if a device (filesystem) should create a device item in e.g Dolphin. BUG: 391706 CCBUG: 389479 REPOSITORY R245 Solid BRANCH revert_empty_filepath_check REVISION DETAIL https://phabricator.kde.org/D12051 AFFECTED FILES src/solid/devices/backends/udisks2/udisksstorageaccess.cpp To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns
