D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 31848. ngraham added a comment. Also add a Sort menu to the toolbar REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31813=31848 BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master)

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham added a comment. To elaborate, the open/save dialog has four view modes: - Simple View: what most other platforms would calll "Icons view". Can be configured to have the icons to the left side of the labels (Windows style), or above them (macOS, GNOME, Cinnamon, XFCE,

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham added a comment. In D12077#243556 , @broulik wrote: > Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most Sure! F5802899: Like this.png

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 31813. ngraham added a comment. Also move the Preview button over to the right, so it doesn't compete with the view mode buttons REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31779=31813 BRANCH

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Marijo Mustac
mmustac added a comment. Great, I even didn't know that this was possible *lol* But wouldn't it be more consistent with dolphin to add the list view also ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: mmustac, broulik, michaelh,

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-10 Thread Kai Uwe Broulik
broulik added a comment. Can we arrange them so that they're more consistent with Dolphin? i.e. put the Preview button at right-most REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-09 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

2018-04-09 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Without this patch, changing the view mode is unnecesarily difficult: you need to click on the settings button in