D12082: Don't offer qml plugin as a link target

2018-04-11 Thread Dan Leinir Turthra Jensen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:469db5c6934b: Dont offer qml plugin as a link 
target (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12082?vs=31790=31859

REVISION DETAIL
  https://phabricator.kde.org/D12082

AFFECTED FILES
  CMakeLists.txt
  KF5NewStuffQuickConfig.cmake.in
  src/qtquick/CMakeLists.txt

To: leinir, #frameworks, #knewstuff, apol
Cc: michaelh, ZrenBot, ngraham, bruns

D12082: Don't offer qml plugin as a link target

2018-04-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D12082

To: leinir, #frameworks, #knewstuff, apol
Cc: michaelh, ZrenBot, ngraham, bruns

D12082: Don't offer qml plugin as a link target

2018-04-10 Thread Dan Leinir Turthra Jensen 
leinir created this revision.
leinir added reviewers: Frameworks, KNewStuff.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
leinir requested review of this revision.

REVISION SUMMARY
  This removes the KNSQuick plugin as a link target for cmake. It was never 
intended to be one, and this was just never picked up as it didn't cause issues 
until attempting to build an app using it on the Windows binary factory. The 
patch also switches to using the KDE QML install locations, equalising it with 
other Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D12082

AFFECTED FILES
  CMakeLists.txt
  KF5NewStuffQuickConfig.cmake.in
  src/qtquick/CMakeLists.txt

To: leinir, #frameworks, #knewstuff
Cc: michaelh, ZrenBot, ngraham, bruns