D12095: convert setDirLister to the new connect syntax

2018-04-11 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:940d2763e41b: convert setDirLister to the new connect syntax (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12095?vs=31851&id=31907 REVISION DET

D12095: convert setDirLister to the new connect syntax

2018-04-11 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12095 To: jtamate, dfaure, #frameworks, apol Cc: apol, michaelh, ngraham, bruns

D12095: convert setDirLister to the new connect syntax

2018-04-10 Thread Jaime Torres Amate
jtamate updated this revision to Diff 31851. jtamate added a comment. Someday, in a not so far future, I'll remember to always look for private slot definitions. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12095?vs=31830&id=31851 REVISION DETAIL https://

D12095: convert setDirLister to the new connect syntax

2018-04-10 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Should remove the private slot declaration? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12095 To: jtamate, dfaure, #frameworks, apol Cc: apol, michaelh, ngraham, bruns

D12095: convert setDirLister to the new connect syntax

2018-04-10 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The only tricky part is the use of QOverload<>::of to distinguish between signals with same name but differ