D12124: Avoid creating duplicate property entries in the cache

2018-04-12 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R245:15047128e56b: Avoid creating duplicate property entries in the cache (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12124?vs=31929=32026

D12124: Avoid creating duplicate property entries in the cache

2018-04-12 Thread Stefan Brüns
bruns added a comment. In D12124#244924 , @broulik wrote: > Wouldn't make a big difference, would it? > > > If there are multiple items for key in the map, the value of the most recently inserted one is returned. > > It's not like we

D12124: Avoid creating duplicate property entries in the cache

2018-04-12 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Wouldn't make a big difference, would it? > If there are multiple items for key in the map, the value of the most recently inserted one is returned. It's not like we actually

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns added a dependent revision: D12125: Avoid inserting an invalid "Size" property from the Filesystem interface. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12124 To: bruns, #frameworks Cc: michaelh, ngraham, bruns

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns updated this revision to Diff 31929. bruns added a comment. update, one line was missing REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12124?vs=31928=31929 BRANCH unique_properties REVISION DETAIL https://phabricator.kde.org/D12124 AFFECTED

D12124: Avoid creating duplicate property entries in the cache

2018-04-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Properties are associated with a specific interface, although the Solid UDisks2 backend merges properties from all