D12130: Use the more user-friendly string "File format" in the save dialogs

[Nathaniel Graham]

ngraham updated this revision to Diff 32030.
ngraham added a comment.


  Use the more familiar and less technical string "File type"

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12130?vs=32018&id=32030

BRANCH
  file-format-label (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12130

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  In D12130#245409 , @bruns wrote:
  
  > In D12130#245373 , @ngraham 
wrote:
  >
  > > Change the text only when saving (it really is a filter bar in open mode)
  >
  >
  > Why not use "File formats" (plural) for the Open dialog?
  
  
  Because in Open mode, it really is a real actual filter box. You can filter 
not only on file type, but also by name. So the text "Filter" is accurate.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Luigi Toscano]

ltoscano added a comment.


  In D12130#245409 , @bruns wrote:
  
  > In D12130#245373 , @ngraham 
wrote:
  >
  > > Change the text only when saving (it really is a filter bar in open mode)
  >
  >
  > Why not use "File formats" (plural) for the Open dialog?
  
  
  Uhm, maybe because you end up choosing one of them.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Stefan Brüns]

bruns added a comment.


  In D12130#245373 , @ngraham wrote:
  
  > Change the text only when saving (it really is a filter bar in open mode)
  
  
  Why not use "File formats" (plural) for the Open dialog?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in kfilewidget.cpp:1338
> I've always said "save as."
> 
> "Save that picture as a JPEG real fast, would ya?"

"Use it to choose which format to use for saving"?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Nathaniel Graham]

ngraham marked 2 inline comments as done.
ngraham added inline comments.

INLINE COMMENTS

> cfeck wrote in kfilewidget.cpp:1338
> Do you say "Save a file as a format" or "Save a file in a format"?

I've always said "save as."

"Save that picture as a JPEG real fast, would ya?"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Nathaniel Graham]

ngraham updated this revision to Diff 32018.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Improve the formatting, and move the label into its own function

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12130?vs=32015&id=32018

BRANCH
  file-format-label (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12130

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1334
> +QString filterWhatsThisText;
>  if (operationMode == KFileWidget::Saving) {
> +locationWhatsThisText = "" + i18n("This is the name to save the 
> file as.") +

I think with an empty line after the QString variable declarations, the 'if' 
can breathe a bit :)

> kfilewidget.cpp:1338
> +filterWhatsThisText = i18n("This is the file type selector. "
> + "Use it to choose what format to save the file 
> as.");
> +q->setFilterLabel(i18n("&File Format:"));

Do you say "Save a file as a format" or "Save a file in a format"?

> kfilewidget.cpp:1339
> + "Use it to choose what format to save the file 
> as.");
> +q->setFilterLabel(i18n("&File Format:"));
>  } else if (ops->mode() & KFile::Files) {

It feels odd that the label is changed in this method. I suggest to move it 
into the function that calls it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the save dialogs

[Nathaniel Graham]

ngraham retitled this revision from "Use the more user-friendly string "File 
format" in the open/save dialogs" to "Use the more user-friendly string "File 
format" in the save dialogs".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: rkflx, alexeymin, abetts, bruns, michaelh, ngraham