D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246301 , @Zren wrote: > > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? > > Hmmm? Ah I missed D11569

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Hmmm? Ah I missed D11569 . So the proposal is we don't show the inline "Open with Gwenview"

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. - Open with "Sublime Text" / "Atom" - Open with "K4DirStat" - Open with "Clementine" Comix, Gwenview, VLC, $MediaPlayer will usually "autoplay" the next file in a folder, so this won't really affect those apps. Do we really need these apps to define a

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Sounds reasonable enough to me. Does anyone else feel otherwise? REPOSITORY R241 KIO REVISION DETAIL

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > "Open with VLC" is of course nonsense. > > > Huh? Not sure I understand. The

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > I find "Open with..." for folders useful. > > > What apps do you typically open

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246282 , @michaelh wrote: > I find "Open with..." for folders useful. What apps do you typically open folders in? What's the use case? In D12206#246282 ,

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. I find "Open with..." for folders useful. "Open with VLC" is of course nonsense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY According to a comment in the code, Open With was never supposed to show up for folders in the first place,