tcberner abandoned this revision.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D12231
To: tcberner, #freebsd, sitter, apol
Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns
apol added a comment.
https://phabricator.kde.org/D12216
Please check the list first...
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D12231
To: tcberner, #freebsd, sitter, apol
Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns
adridg added a comment.
Since you're using a global variable to accumulate ${numberOfProcesses} worth
of po-files in one go, you should definitely clear out the variable when that
bunch has been processed, or you'll grind through each po file more than once
(with a growing command-list,
anthonyfieroni added inline comments.
INLINE COMMENTS
> build-pofiles.cmake:31
> include(ProcessorCount)
> ProcessorCount(numberOfProcesses)
>
you can downgrade by 1 numberOfProcesses, BTW it's best value to have *alive*
system.
PS: Probably you should check -1 if it's > 1
REPOSITORY
tcberner updated this revision to Diff 32216.
tcberner added a comment.
Simplify the diff.
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12231?vs=32210=32216
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12231
AFFECTED FILES
tcberner added inline comments.
INLINE COMMENTS
> build-pofiles.cmake:64
> set(i 0)
> +set(commands "")
> endif()
^ this is probalby the only required change.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D12231
To: tcberner, #freebsd, sitter,
tcberner created this revision.
tcberner added reviewers: FreeBSD, sitter, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tcberner requested review of this revision.
REVISION SUMMARY
With Frameworks 5.45 [1] when building for
