D12242: KJob public signals

2018-04-16 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:c0b312a41f7f: KJob public signals (authored by jtamate).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12242?vs=32267&id=32307

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

2018-04-16 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

2018-04-16 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 32267.
jtamate added a comment.


  Changed from "can't" to "shouldn't".

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12242?vs=32258&id=32267

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

2018-04-16 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kjob.h:472
>   *
> - * This is a private signal, it can't be emitted directly by subclasses 
> of
> + * @note: This is a private signal, it can't be emitted directly by 
> subclasses of
>   * KJob, use setTotalAmount() instead.

"can't" should now be "shouldn't", since it's now technically possible, just 
strongly discouraged.

If we leave "can't" and someone tries it, it will work, and they'll think there 
is no problem then ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

2018-04-16 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  KIO::KCoreDirLister connects to those signals, they must be public so the new 
connect syntax compiles.

TEST PLAN
  kio compiles with new connect syntax.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns