D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Done in D19849 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

anemeth abandoned this revision. anemeth added a comment. @ngraham I'm sorry, but because of my new job I don't have much free time left so I can't actively develop anymore. I'd really like if someone took over this patch. REPOSITORY R241 KIO REVISION DETAIL

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. @anemeth, any updates on this? Do you need a hand with anything? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

rkflx resigned from this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#256043 , @anemeth wrote: > I'm thinking about abandoning this revision in favor of proper tab ordering instead. As Nate already said, tabstop ordering would also be good to have. But given that the

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. In D12545#256043 , @anemeth wrote: > In D12545#254473 , @rkflx wrote: > > > I could imagine a different spin here: [⇥] should switch focus from the item view to the name

D12545: Set focus on the filename line edit when a file is selected

anemeth added a comment. In D12545#254473 , @rkflx wrote: > I could imagine a different spin here: [⇥] should switch focus from the item view to the name line edit, which it currently does not. (And as the dialog starts with focus on the name

D12545: Set focus on the filename line edit when a file is selected

rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Good point. :) So yes, this is an enhancement for the double-click use case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#254479 , @ngraham wrote: > No, it doesn't actually work. Turn on double-click, Aha! This is what I'm missing. It should be mentioned in the summary if non-default settings are used :D REPOSITORY R241

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. In D12545#254477 , @rkflx wrote: > In D12545#254475 , @ngraham wrote: > > > Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior

D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#254475 , @ngraham wrote: > Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior only when clicking, and only for the save dialog. Yeah, but not sure I

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior only when clicking, and only for the save dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham,

D12545: Set focus on the filename line edit when a file is selected

rkflx requested changes to this revision. rkflx added a comment. Hm, this breaks selecting files and even navigating directories with the keyboard (e.g. via the arrow keys), and as such cannot possibly be something we want. I could imagine a different spin here: [⇥] should switch focus

D12545: Set focus on the filename line edit when a file is selected

ngraham added a dependent revision: D12544: Don't select file extension. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This is clearly what the code was //trying// to do, based on inline comments: https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176 However, are we sure

D12545: Set focus on the filename line edit when a file is selected

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg Cc: ngraham,

D12545: Set focus on the filename line edit when a file is selected

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH focus_lineedit (branched from master) REVISION DETAIL