D13124: Add Share action to Dolphin context menu

2018-07-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:efbb952f10b3: Add Share action to Dolphin context menu (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=37052=37102

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Mark Gaiser
markg added a comment. In D13124#286263 , @elvisangelaccio wrote: > In D13124#286115 , @broulik wrote: > > > Check out `KFileItemActions::addServiceActionsTo` > > > Actually,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. In D13124#286115 , @broulik wrote: > Check out `KFileItemActions::addServiceActionsTo` Actually,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Nicolas Fella
nicolasfella added a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, #dolphin Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Kai Uwe Broulik
broulik added a comment. Check out `KFileItemActions::addServiceActionsTo` REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Mark Gaiser
markg added a comment. This looks great! But i don't get how it is magically included in Dolphin.. Perhaps someone could explain? I get that it's a fileitemaction plugin and that it's being loaded by dolphin (somehow), i take that for granted. But even so, if i look in the dolphin

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Aleix Pol Gonzalez
apol added a comment. Looks good to me, would appreciate if someone from dolphin could accept. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Nicolas Fella
nicolasfella retitled this revision from "[RFC] Add Share action to Dolphin context menu" to "Add Share action to Dolphin context menu". REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel,