D13425: File indexer closing improvements.

2019-06-16 Thread James Smith 
smithjd abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-11 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  The content and summary still do not match.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith 
smithjd updated this revision to Diff 43368.
smithjd added a comment.


  Rebase.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13425?vs=43363=43368

BRANCH
  master-scheduler-haltonquit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13425

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread Stefan Brüns 
bruns added a comment.


  The summary does in no way match the change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mainhub.cpp:72
>  m_config->forceConfigUpdate();
> -// FIXME!!
> -//m_fileIndexer.updateConfig();

Unrelated change

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith 
smithjd added a comment.


  https://bugs.kde.org/show_bug.cgi?id=353559

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread Nathaniel Graham 
ngraham added reviewers: Baloo, poboiko.
ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=373430 and/or 
https://bugs.kde.org/show_bug.cgi?id=353559?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith 
smithjd updated this revision to Diff 43363.
smithjd added a comment.


  Rebase.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13425?vs=43361=43363

BRANCH
  master-scheduler-watchesInstalled (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13425

AFFECTED FILES
  src/file/mainhub.cpp

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith 
smithjd updated this revision to Diff 43361.
smithjd added a comment.


  Rebase.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13425?vs=40344=43361

BRANCH
  master-scheduler-haltonquit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13425

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/mainhub.cpp

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, abrahams

D13425: File indexer closing improvements.

2018-08-23 Thread James Smith 
smithjd updated this revision to Diff 40344.
smithjd added a comment.


  Rebase.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13425?vs=36702=40344

BRANCH
  master-scheduler-haltonquit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13425

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexerstate.h
  src/file/mainhub.cpp
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, abrahams

D13425: File indexer closing improvements.

2018-06-26 Thread James Smith 
smithjd retitled this revision from "file indexer closing inprovements." to 
"File indexer closing improvements.".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, abrahams