D13502: Fix compiler warning about hidden virtual overloads

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7b9932e70739: Fix compiler warning about hidden virtual overloads (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13502?vs=36073&id=36

D13502: Fix compiler warning about hidden virtual overloads

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In D13502#277837 , @davidedmundson wrote: > ... > But if this is accepted as a good solution for the problem, ... Well, yeah, that's pr

D13502: Fix compiler warning about hidden virtual overloads

davidedmundson added a comment. Yes, but it gets complex with the existing XDGShell having a tonne of other changes on phab. But if this is accepted as a good solution for the problem, I'll fixup XDGShell when we merge that. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator

D13502: Fix compiler warning about hidden virtual overloads

zzag added a comment. In D13502#277828 , @davidedmundson wrote: > I meant the class I changed no longer had warnings. Oh, I thought you were talking about all -Woverloaded-virtual warnings. I think it would be better to fix those warning

D13502: Fix compiler warning about hidden virtual overloads

davidedmundson added a comment. I meant the class I changed no longer had warnings. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13502 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

zzag added a comment. > Compiles with no warnings \o/ Nope. In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20: /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:49:13: warning: ‘virtual KWayland::Client::XdgShell::Private::

D13502: Fix compiler warning about hidden virtual overloads

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY TextInput has 4 virtual operators f