D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:bb56c91ede0f: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13941?vs=37307=37393

REVISION DETAIL
  https://phabricator.kde.org/D13941

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13941: Honor BUILD_TESTING

2018-07-08 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13941

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas 
arojas added a comment.


  There's more stuff being built inside tests and autotests besides 
ecm_add_tests

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13941

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13941: Honor BUILD_TESTING

2018-07-08 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Isn't `BUILD_TESTING` already honored by `ecm_add_tests` ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13941

To: arojas, dfaure
Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13941: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Only build tests if BUILD_TESTING is on

TEST PLAN
  Builds

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13941

AFFECTED FILES
  CMakeLists.txt

To: arojas, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns